Skip to content

feat: added async support - #135

Merged
peterdeme merged 3 commits into
mainfrom
async
Apr 21, 2022
Merged

feat: added async support#135
peterdeme merged 3 commits into
mainfrom
async

Conversation

@peterdeme

@peterdeme peterdeme commented Feb 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Async implementatiom by @Werded
I opened this PR because I have permission to run CI on it since I'm part of Stream.

@peterdeme
peterdeme requested a review from ferhatelmas February 2, 2022 15:51
@peterdeme peterdeme mentioned this pull request Feb 2, 2022
Closed
6 tasks
@peterdeme
peterdeme force-pushed the async branch 3 times, most recently from 4651d2d to f5990b1 Compare February 2, 2022 16:16
@ferhatelmas

ferhatelmas commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

@peterdeme I updated its configs, should be good now to run

@Werded

Werded commented Feb 11, 2022

Copy link
Copy Markdown

is this something wrong with tests or it's something wrong on getstream server?

@ferhatelmas

ferhatelmas commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

is this something wrong with tests or it's something wrong on getstream server?

It's in staging environment, we're testing couple of other things. Will update today.

@Werded

Werded commented Feb 21, 2022

Copy link
Copy Markdown

is this something wrong with tests or it's something wrong on getstream server?

It's in staging environment, we're testing couple of other things. Will update today.
any progress?

@peterdeme

peterdeme commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

@ferhatelmas can you create a new application and add the API key/secret combo to the repo secrets? 🙏

github-actions[bot]
github-actions Bot reviewed Apr 21, 2022
View reviewed changes
Comment thread stream/reactions/__init__.py
Comment thread stream/reactions/__init__.py
Comment thread stream/client/__init__.py
Comment thread stream/client/__init__.py
Comment thread stream/client/client.py
Comment thread stream/personalization/__init__.py
Comment thread stream/users/__init__.py
Comment thread stream/users/__init__.py
Comment thread stream/feed/__init__.py
Comment thread stream/feed/__init__.py
@ferhatelmas

ferhatelmas commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

@ferhatelmas can you create a new application and add the API key/secret combo to the repo secrets? pray

@peterdeme it's good to go to me but check the last commits for second look

@peterdeme
peterdeme merged commit b4515d3 into main Apr 21, 2022
@peterdeme
peterdeme deleted the async branch April 21, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
+1 more reviewer
@ferhatelmas ferhatelmas ferhatelmas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterdeme @ferhatelmas @Werded