Skip to content

Add support for tagged html template strings - #5

Merged
Benvie merged 1 commit into
Benvie:masterfrom
emedvedev:tagged-html
Jul 16, 2018
Merged

Add support for tagged html template strings#5
Benvie merged 1 commit into
Benvie:masterfrom
emedvedev:tagged-html

Conversation

@emedvedev

Copy link
Copy Markdown
Contributor

A companion PR to babel/babel-sublime#350, since the feature is missing there as well :)

screenshot 2018-02-15 02 58 34

Adds support for HTML highlighting inside template literals tagged with an html function. Support for this feature has been implemented in Babel highlighting for Atom for a while, and even GitHub highlights it like it's supposed to (thanks @DylanPiercey for pointing that out in babel/babel-sublime#138 (comment)):

const it = html`
  <div>hi</div>
`

It's also a fairly important part of Polymer starting from 2.4. As the Polymer documentation puts it:

Some text editors support HTML code highlighting in JavaScript template literals tagged with a function called html.

@emedvedev

Copy link
Copy Markdown
Contributor Author

@Benvie would it be possible to merge this and update the package?

@Benvie

Benvie commented May 1, 2018

Copy link
Copy Markdown
Owner

Thanks for the heads up. I didn’t get a notification for this for some reason.

@jsilvermist

Copy link
Copy Markdown

@Benvie Any updates on this? With Polymer 3 just released not having this syntax highlighting is a major issue.

@Benvie
Benvie merged commit 83b1d91 into Benvie:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants