Skip to content
This repository was archived by the owner on Jun 18, 2020. It is now read-only.

cast OnForeground to uv_after_work_cb - #122

Merged
jkint merged 1 commit into
masterfrom
unknown repository
Jul 23, 2013
Merged

cast OnForeground to uv_after_work_cb#122
jkint merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 30, 2013

Copy link
Copy Markdown

Without this directive, compilation fails with node 0.10.x

Without this directive, compilation fails with node 0.10.x
@jkint

jkint commented Apr 2, 2013

Copy link
Copy Markdown
Contributor

Thanks so much for this contribution. Unfortunately I don't see your name in our CLA database. Would you mind following the guidelines in our CONTRIBUTIONS.md so that I can merge this pull request?

Thanks again.

@ghost

ghost commented Apr 4, 2013

Copy link
Copy Markdown
Author

Ok, I'll let you know when it's all done.

-Cris

@ghost

ghost commented Apr 5, 2013

Copy link
Copy Markdown
Author

I submitted the form just now. I'll let you know when I get a response.

-Cris

@jnicholls

Copy link
Copy Markdown

looking forward to this being merged and an update on npm :)

@jkint

jkint commented Apr 16, 2013

Copy link
Copy Markdown
Contributor

As am I. Awaiting approval is all. Thanks. :)

@ghost ghost assigned jkint Apr 16, 2013
@ghost

ghost commented Apr 17, 2013

Copy link
Copy Markdown
Author

I haven't gotten a response (or an acknowledgment), so I'm getting a bit concerned that the form was not received.

@jkint

jkint commented Apr 17, 2013

Copy link
Copy Markdown
Contributor

I'm trying to track it down on our side as well. It's not (yet) in our database.

@kevinwucodes

Copy link
Copy Markdown

any updates?

@jkint

jkint commented Apr 19, 2013

Copy link
Copy Markdown
Contributor

Not yet. We had a change of personnel and information on approving CLAs was lost in the shuffle. We are working to approve and pull this request as soon as we can.

Thanks for your patience.

@kevinwucodes

Copy link
Copy Markdown

jkint, any luck on getting this approved?

@Brian-Cole

Copy link
Copy Markdown

I can confirm that this works on 0.10.x

@CnApTaK

CnApTaK commented May 15, 2013

Copy link
Copy Markdown

me too

@jkint

jkint commented May 21, 2013

Copy link
Copy Markdown
Contributor

No. No luck in finding it. @cravergara, could you please submit another CLA? I've received a few in the last few days, so I know the reporting is working now. Unfortunately yours seems to have been lost... Sorry about that.

@ghost

ghost commented May 22, 2013

Copy link
Copy Markdown
Author

I sent it again. Let me know if you got it.

@mercan01

Copy link
Copy Markdown

@jkint Any updates?

@ghost

ghost commented Jun 13, 2013

Copy link
Copy Markdown
Author

I did get a confirmation that my CLA was received. No word on merging though...

jkint added a commit that referenced this pull request Jul 23, 2013
cast OnForeground to uv_after_work_cb
@jkint
jkint merged commit 586300d into Azure:master Jul 23, 2013
@ghost ghost unassigned jkint Apr 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants