Move row properties into the document editor#248
Merged
Conversation
…-properties-block-v2 # Conflicts: # docs/tech-debt.md # includes/CLI/PerfBench.php # includes/Documents.php # includes/PostType/Collection.php # includes/Rest/DocumentsController.php # src/blocks/data-view/edit.js # src/components/Canvas.js # src/components/CollectionRow.js # src/components/PageRow.js # src/components/PublishToggle.js # src/components/Sidebar.js # src/index.scss # tests/js/components/CollectionRow.test.js # tests/js/components/PageRow.test.js
Unpinned side peeks dismiss on certain interactions during row navigation; the assertions raced against the dialog closing, causing the route handler to error and the post-navigation expect to hit a closed page.
The properties block also exposes Hide/Show fields in its block toolbar, so a dialog-level locator hits two buttons. Also wrap the delayed route handler in try/catch so it does not error if the route was already handled by the time the timeout elapses.
…-properties-block-v2
…-properties-block-v2 # Conflicts: # src/components/Canvas.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #131.
Row properties now live inside the editor canvas, between the title and body, as a locked
cortext/document-propertiesblock. The same block is used in full-page rows and row detail, with controls to hide/show fields and add new ones from the toolbar or inspector.Why
This removes the odd split where row fields looked like document content but still lived in Cortext chrome outside the editor. Rows now behave more like documents, and the block is in place for the later public render work.
How
Testing Instructions
Screen recording
Grabacion.de.pantalla.2026-05-22.a.las.20.45.22.mov