Polish DataView block layout#194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Polishes the embedded data-view block layout. Short tables now hug their content instead of sitting inside a fixed 640px box, and long tables can keep growing with the document. The block selection outline also stays visible around the table, pagination, and New row button.
This also tightens the actions column so it only takes the space needed for the kebab /
+controls, and keeps shorter cells centered when another cell makes the row taller.Why
Small embedded tables looked oddly tall, and the pagination footer could cut through Gutenberg's blue selection outline. The actions column had a similar polish issue: it inherited the generic table-cell width, which wasted space and could push real data under the sticky-right edge.
Testing Instructions
cortext/data-viewblock with a short collection.+controls.Screenshots