Fix content collection edits serving stale content in dev on Windows - #17755
Merged
Conversation
The dev server relied on the file watcher observing the atomic rename that commits a data store write to invalidate the content virtual modules. On Windows the watcher can miss that event, leaving dev serving stale content until a restart (#17335). The store now notifies listeners after real disk writes and the dev server invalidates directly, keeping the watcher path as a fallback for other processes with echo suppression to avoid double reloads.
🦋 Changeset detectedLatest commit: e5282ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 422 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
matthewp
marked this pull request as ready for review
August 27, 2026 15:44
Contributor
Author
|
Verified by a user: #17335 (comment) |
Princesseuh
approved these changes
Aug 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
store-write-notifications.test.ts: write notifications fire for the store file (single-file and chunked), asset imports file, not for identical data, and stop after unsubscribe.content-virtual-mod.test.ts: simulates the Windows failure mode. A store write with no watcher event still invalidates and reloads once, the watcher echo is skipped, and a later external watcher event still invalidates.Docs