fix: invalid internal declarations (#17869)

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>

Author: ematipico

.changeset/clear-pets-help.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a case where the logger was improperly initialized at runtime in dev.

packages/astro/dev-only.d.ts

@@ -24,34 +24,29 @@ declare module 'virtual:astro:actions/options' {
 }
 
 declare module 'virtual:astro:actions/entrypoint' {
-	import type { SSRActions } from './src/index.js';
-	export const server: SSRActions;
+	export const server: import('./src/index.js').SSRActions;
 }
 
 declare module 'virtual:astro:manifest' {
-	import type { SSRManifest } from './src/index.js';
-	export const manifest: SSRManifest;
+	export const manifest: import('./src/index.js').SSRManifest;
 }
 
 declare module 'virtual:astro:routes' {
-	import type { RoutesList } from './src/types/astro.js';
-	export const routes: RoutesList[];
+	export const routes: import('./src/core/app/types.js').RouteInfo[];
 }
 
 declare module 'virtual:astro:renderers' {
-	import type { AstroRenderer } from './src/index.js';
-	export const renderers: AstroRenderer[];
+	export const renderers: import('./src/index.js').AstroRenderer[];
 }
 
 declare module 'virtual:astro:middleware' {
-	import type { AstroMiddlewareInstance } from './src/index.js';
-	const middleware: AstroMiddlewareInstance;
+	const middleware: import('./src/index.js').AstroMiddlewareInstance;
 	export default middleware;
+	export = middleware;
 }
 
 declare module 'virtual:astro:session-driver' {
-	import type { Driver } from 'unstorage';
-	export const driver: Driver;
+	export const driver: import('unstorage').Driver;
 }
 
 declare module 'virtual:astro:pages' {
@@ -73,18 +68,21 @@ declare module 'virtual:astro:adapter-config' {
 }
 
 declare module 'virtual:astro:dev-css' {
-	import type { ImportedDevStyles } from './src/types/astro.js';
-	export const css: Set<ImportedDevStyles>;
+	export const css: Set<import('./src/types/astro.js').ImportedDevStyles>;
 }
 
 declare module 'virtual:astro:dev-css-all' {
-	import type { ImportedDevStyles } from './src/types/astro.js';
-	export const devCSSMap: Map<string, () => Promise<{ css: Set<ImportedDevStyles> }>>;
+	export const devCSSMap: Map<
+		string,
+		() => Promise<{ css: Set<import('./src/types/astro.js').ImportedDevStyles> }>
+	>;
 }
 
 declare module 'virtual:astro:component-metadata' {
-	import type { SSRComponentMetadata } from './src/types/public/internal.js';
-	export const componentMetadataEntries: [string, SSRComponentMetadata][];
+	export const componentMetadataEntries: [
+		string,
+		import('./src/types/public/internal.js').SSRComponentMetadata,
+	][];
 }
 
 declare module 'virtual:astro:app' {

packages/astro/src/core/app/entrypoints/virtual/dev.ts

@@ -21,7 +21,7 @@ let hmrWired = false;
 export const createApp: CreateApp = ({ streaming } = {}) => {
 	// Composition order: logger → environment → facade ctor
 	// (which warms the route table) → fetch handler → HMR wiring.
-	setLogger(manifest, createConsoleLogger(manifest.logLevel));
+	setLogger(manifest, createConsoleLogger({ level: manifest.logLevel }));
 	setEnvironment(manifest, createNonRunnableEnvironment());
 	const app = new DevFacadeApp(manifest, streaming);
 	app.setFetchHandler(fetchable);
@@ -38,7 +38,7 @@ export const createApp: CreateApp = ({ streaming } = {}) => {
 				const { routes: newRoutes } = await import('virtual:astro:routes');
 				updateRouteTable(
 					manifest,
-					newRoutes.map((r: RouteInfo) => r.routeData),
+					newRoutes.map((route: RouteInfo) => route.routeData),
 				);
 			} catch (e: any) {
 				// Log error but don't crash - route updates are non-critical

packages/astro/src/vite-plugin-app/createAstroServerApp.ts

@@ -73,7 +73,7 @@ export default async function createAstroServerApp(
 				const { routes: newRoutes } = await import('virtual:astro:routes');
 				updateRouteTable(
 					manifest,
-					newRoutes.map((r: RouteInfo) => r.routeData),
+					newRoutes.map((route: RouteInfo) => route.routeData),
 				);
 				actualLogger.debug('router', 'Routes updated via HMR');
 			} catch (e: any) {