Use instanceof instead of type

Adjusted conditional statements to use instanceof when
comparing variables. Instanceof supports inheritance type
checking better than type.

Change-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c
Closes-Bug: 1548530

Author: Brandon Palm

openstackclient/api/api.py

@@ -243,14 +243,14 @@ def find_attr(
         def getlist(kw):
             """Do list call, unwrap resource dict if present"""
             ret = self.list(path, **kw)
-            if type(ret) == dict and resource in ret:
+            if isinstance(ret, dict) and resource in ret:
                 ret = ret[resource]
             return ret
 
         # Search by attribute
         kwargs = {attr: value}
         data = getlist(kwargs)
-        if type(data) == dict:
+        if isinstance(data, dict):
             return data
         if len(data) == 1:
             return data[0]
@@ -283,7 +283,7 @@ def find_bulk(
         """
 
         items = self.list(path)
-        if type(items) == dict:
+        if isinstance(items, dict):
             # strip off the enclosing dict
             key = list(items.keys())[0]
             items = items[key]

openstackclient/api/utils.py

@@ -61,7 +61,7 @@ def simple_filter(
             # Searching data fields
             search_value = d[attr]
         elif (property_field and property_field in d and
-                type(d[property_field]) is dict):
+                isinstance(d[property_field], dict)):
             # Searching a properties field - do this separately because
             # we don't want to fail over to checking the fields if a
             # property name is given.

openstackclient/tests/test_shell.py

@@ -317,7 +317,7 @@ def _test_options_init_app(self, test_opts):
             if not test_opts[opt][1]:
                 continue
             key = opt2attr(opt)
-            if type(test_opts[opt][0]) is str:
+            if isinstance(test_opts[opt][0], str):
                 cmd = opt + " " + test_opts[opt][0]
             else:
                 cmd = opt
@@ -331,7 +331,7 @@ def _test_options_get_one_cloud(self, test_opts):
             if not test_opts[opt][1]:
                 continue
             key = opt2attr(opt)
-            if type(test_opts[opt][0]) is str:
+            if isinstance(test_opts[opt][0], str):
                 cmd = opt + " " + test_opts[opt][0]
             else:
                 cmd = opt