From bb2815ac3d44f8e43ddeb565d8f37880a4be502e Mon Sep 17 00:00:00 2001 From: Aritra Roy Date: Thu, 27 Apr 2017 16:17:39 +0530 Subject: [PATCH 1/5] Fixed minor issue with reactive extension --- .../PatternLockViewCompleteObservable.java | 14 +++++++------- .../PatternLockViewProgressObservable.java | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewCompleteObservable.java b/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewCompleteObservable.java index 26ae6f3..85fab78 100644 --- a/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewCompleteObservable.java +++ b/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewCompleteObservable.java @@ -22,17 +22,17 @@ public PatternLockViewCompleteObservable(PatternLockView patternLockView, boolea @Override protected void subscribeListener(Observer observer) { - subscribeListener(observer); - if (mEmitInitialValue) { - observer.onNext(new PatternLockCompleteEvent(mPatternLockView.getPattern())); - } + InternalListener internalListener = new InternalListener(mPatternLockView, observer); + observer.onSubscribe(internalListener); + mPatternLockView.addPatternLockListener(internalListener); } @Override protected void subscribeActual(Observer observer) { - InternalListener internalListener = new InternalListener(mPatternLockView, observer); - observer.onSubscribe(internalListener); - mPatternLockView.addPatternLockListener(internalListener); + subscribeListener(observer); + if (mEmitInitialValue) { + observer.onNext(new PatternLockCompleteEvent(mPatternLockView.getPattern())); + } } private static final class InternalListener extends MainThreadDisposable diff --git a/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewProgressObservable.java b/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewProgressObservable.java index bd1e598..8597ab8 100644 --- a/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewProgressObservable.java +++ b/patternlockview-reactive/src/main/java/com/andrognito/rxpatternlockview/observables/PatternLockViewProgressObservable.java @@ -22,17 +22,17 @@ public PatternLockViewProgressObservable(PatternLockView patternLockView, boolea @Override protected void subscribeListener(Observer observer) { - subscribeListener(observer); - if (mEmitInitialValue) { - observer.onNext(new PatternLockProgressEvent(mPatternLockView.getPattern())); - } + InternalListener internalListener = new InternalListener(mPatternLockView, observer); + observer.onSubscribe(internalListener); + mPatternLockView.addPatternLockListener(internalListener); } @Override protected void subscribeActual(Observer observer) { - InternalListener internalListener = new InternalListener(mPatternLockView, observer); - observer.onSubscribe(internalListener); - mPatternLockView.addPatternLockListener(internalListener); + subscribeListener(observer); + if (mEmitInitialValue) { + observer.onNext(new PatternLockProgressEvent(mPatternLockView.getPattern())); + } } private static final class InternalListener extends MainThreadDisposable From b69afae9c1514cc793e49ad6d62947a4de31fa15 Mon Sep 17 00:00:00 2001 From: Aritra Roy Date: Fri, 28 Jul 2017 20:34:25 +0530 Subject: [PATCH 2/5] Updated Twitter Handle --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cd9e825..1ec38d2 100644 --- a/README.md +++ b/README.md @@ -175,7 +175,7 @@ Android & Backend Developer. Blogger. Designer. Fitness Enthusiast. - + # License From b5502eb3297ef89dbbf7fde5c4bcef6695299329 Mon Sep 17 00:00:00 2001 From: Aritra Roy Date: Sat, 29 Jul 2017 14:11:51 +0530 Subject: [PATCH 3/5] Added LinkedIn Profile --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 1ec38d2..e633f71 100644 --- a/README.md +++ b/README.md @@ -176,6 +176,7 @@ Android & Backend Developer. Blogger. Designer. Fitness Enthusiast. + # License From 329072d681c2180f4c705f1edf492f389b1f503c Mon Sep 17 00:00:00 2001 From: Aritra Roy Date: Sat, 3 Mar 2018 22:02:07 +0530 Subject: [PATCH 4/5] Updated Twitter handle --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e633f71..169e198 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ dependencies { ### Spread Some :heart: [![GitHub stars](https://img.shields.io/github/stars/aritraroy/PatternLockView.svg?style=social&label=Star)](https://github.com/aritraroy) [![GitHub followers](https://img.shields.io/github/followers/aritraroy.svg?style=social&label=Follow)](https://github.com/aritraroy) -[![Twitter Follow](https://img.shields.io/twitter/follow/aritraroy93.svg?style=social)](https://twitter.com/aritraroy93) +[![Twitter Follow](https://img.shields.io/twitter/follow/aritraroy93.svg?style=social)](https://twitter.com/aritraroy) # Usage From a90b0d4bf0f286bc23e0356a260b6929adebe7de Mon Sep 17 00:00:00 2001 From: Aritra Roy Date: Sat, 3 Mar 2018 22:03:03 +0530 Subject: [PATCH 5/5] Updated Twitter badge --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 169e198..a07896e 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ dependencies { ### Spread Some :heart: [![GitHub stars](https://img.shields.io/github/stars/aritraroy/PatternLockView.svg?style=social&label=Star)](https://github.com/aritraroy) [![GitHub followers](https://img.shields.io/github/followers/aritraroy.svg?style=social&label=Follow)](https://github.com/aritraroy) -[![Twitter Follow](https://img.shields.io/twitter/follow/aritraroy93.svg?style=social)](https://twitter.com/aritraroy) +[![Twitter Follow](https://img.shields.io/twitter/follow/aritraroy.svg?style=social)](https://twitter.com/aritraroy) # Usage