-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: odinsbane/scripting-java
base: master
head repository: scijava/scripting-java
compare: main
- 14 commits
- 13 files changed
- 3 contributors
Commits on Aug 14, 2025
-
Switched using classloader to using classgraph library.
Matt committedAug 14, 2025 Configuration menu - View commit details
-
Copy full SHA for 714c514 - Browse repository at this point
Copy the full SHA 714c514View commit details -
Merge pull request scijava#15 from odinsbane/fixing-classpath
Switched using classloader to using classgraph library.
Configuration menu - View commit details
-
Copy full SHA for 029c740 - Browse repository at this point
Copy the full SHA 029c740View commit details -
Configuration menu - View commit details
-
Copy full SHA for b72274b - Browse repository at this point
Copy the full SHA b72274bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3fecc7 - Browse repository at this point
Copy the full SHA c3fecc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40cb95d - Browse repository at this point
Copy the full SHA 40cb95dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6918c0 - Browse repository at this point
Copy the full SHA d6918c0View commit details -
POM: bump version to 1.0.0-SNAPSHOT
It's past time to start deploying SciJava components like this one to Maven Central!
Configuration menu - View commit details
-
Copy full SHA for 31fd9c6 - Browse repository at this point
Copy the full SHA 31fd9c6View commit details -
POM: use HTTPS for schema location URL
Maven no longer supports plain HTTP for the schema location. And using HTTP now generates errors in Eclipse (and probably other IDEs).
Configuration menu - View commit details
-
Copy full SHA for e8af761 - Browse repository at this point
Copy the full SHA e8af761View commit details -
Bump to next development cycle
Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
Configuration menu - View commit details
-
Copy full SHA for 4b1c9dd - Browse repository at this point
Copy the full SHA 4b1c9ddView commit details
Commits on Jun 14, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 2d382bf - Browse repository at this point
Copy the full SHA 2d382bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b63325f - Browse repository at this point
Copy the full SHA b63325fView commit details
Commits on Jun 15, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 9ae808e - Browse repository at this point
Copy the full SHA 9ae808eView commit details -
Fix extraneous whitespace in generated POM files
With Java 11 only (not 8, 17, or 21!), tests failed with errors like: java.lang.AssertionError: Unexpected: META-INF/maven/ org.scijava.scripting.java / Dummy /pom.xml Cause: the generated pom.xml has whitespace-polluted <groupId>, <artifactId>, and <version> values. Here's what was happening: 1. fakePOM() builds an XML document where each element's content is stored as a CDATA section via document.createCDATASection(content). 2. The transformer is configured with OutputKeys.INDENT = "yes". 3. In Java 8 (Xalan), the transformer writes CDATA content inline: <groupId><![CDATA[org.scijava.scripting.java]]></groupId>. 4. In Java 11, the internal XSLT transformer changed its indentation behavior for CDATA nodes — it treats a CDATA section as a child node distinct from inline text, and inserts a newline + indent before it and after it: <groupId> <![CDATA[org.scijava.scripting.java]]> </groupId> 5. When MiniMaven parses this POM back, getTextContent() on <groupId> returns "\n org.scijava.scripting.java\n ", which then gets embedded verbatim into the JAR entry path and into download URLs — causing the MalformedURLException and the wrong JAR entry names. The fix is in the append method: replace createCDATASection with createTextNode. XSLT transformers universally treat text-only elements (those with a single text-node child and no element children) as opaque and don't inject indentation whitespace inside them. CDATA sections and text nodes are semantically identical in XML, but Java 11's XSLT transformer treats a CDATA node as a distinct child and wraps it with indentation whitespace when INDENT=yes. Plain text nodes in text-only elements are left inline. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>Configuration menu - View commit details
-
Copy full SHA for b7075bd - Browse repository at this point
Copy the full SHA b7075bdView commit details -
Bump to next development cycle
Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
Configuration menu - View commit details
-
Copy full SHA for a0534cd - Browse repository at this point
Copy the full SHA a0534cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...main