Remove ArgumentEscaper (dotnet#32134)

Author: pranavkm

src/Shared/CommandLineUtils/Utilities/ArgumentEscaper.cs

@@ -18,17 +18,19 @@ public static int Run(
             string workingDirectory = null,
             bool interceptOutput = false)
         {
-            var arguments = ArgumentEscaper.EscapeAndConcatenate(args);
-
-            reporter.WriteVerbose(executable + " " + arguments);
+            reporter.WriteVerbose(executable + " " + string.Join(" " , args));
 
             var startInfo = new ProcessStartInfo
             {
                 FileName = executable,
-                Arguments = arguments,
                 UseShellExecute = false,
                 RedirectStandardOutput = interceptOutput
             };
+            foreach (var argument in args)
+            {
+                startInfo.ArgumentList.Add(argument);
+            }
+
             if (workingDirectory != null)
             {
                 startInfo.WorkingDirectory = workingDirectory;

src/Shared/test/Shared.Tests/ArgumentEscaperTests.cs

@@ -43,25 +43,24 @@ public string Resolve(string project, string configuration)
             var outputFile = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
             try
             {
-                var args = new[]
-                {
-                    "msbuild",
-                    projectFile,
-                    "/nologo",
-                    "/t:_ExtractUserSecretsMetadata", // defined in SecretManager.targets
-                    "/p:_UserSecretsMetadataFile=" + outputFile,
-                    "/p:Configuration=" + configuration,
-                    "/p:CustomAfterMicrosoftCommonTargets=" + _targetsFile,
-                    "/p:CustomAfterMicrosoftCommonCrossTargetingTargets=" + _targetsFile,
-                    "-verbosity:detailed",
-                };
                 var psi = new ProcessStartInfo
                 {
                     FileName = DotNetMuxer.MuxerPathOrDefault(),
-                    Arguments = ArgumentEscaper.EscapeAndConcatenate(args),
                     RedirectStandardOutput = true,
                     RedirectStandardError = true,
                     UseShellExecute = false,
+                    ArgumentList =
+                    {
+                        "msbuild",
+                        projectFile,
+                        "/nologo",
+                        "/t:_ExtractUserSecretsMetadata", // defined in SecretManager.targets
+                        "/p:_UserSecretsMetadataFile=" + outputFile,
+                        "/p:Configuration=" + configuration,
+                        "/p:CustomAfterMicrosoftCommonTargets=" + _targetsFile,
+                        "/p:CustomAfterMicrosoftCommonCrossTargetingTargets=" + _targetsFile,
+                        "-verbosity:detailed",
+                    }
                 };
 
 #if DEBUG