provider/azurerm: create virtual_network_peering resource (hashicorp#8168)

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMVirtualNetworkPeering -timeout 120m
=== RUN   TestAccAzureRMVirtualNetworkPeering_importBasic
--- PASS: TestAccAzureRMVirtualNetworkPeering_importBasic (225.50s)
=== RUN   TestAccAzureRMVirtualNetworkPeering_basic
--- PASS: TestAccAzureRMVirtualNetworkPeering_basic (216.95s)
=== RUN   TestAccAzureRMVirtualNetworkPeering_update
--- PASS: TestAccAzureRMVirtualNetworkPeering_update (266.97s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	709.545s

Author: pmcatominey

builtin/providers/azurerm/config.go

@@ -45,6 +45,7 @@ type ArmClient struct {
 	vnetGatewayConnectionsClient network.VirtualNetworkGatewayConnectionsClient
 	vnetGatewayClient            network.VirtualNetworkGatewaysClient
 	vnetClient                   network.VirtualNetworksClient
+	vnetPeeringsClient           network.VirtualNetworkPeeringsClient
 	routeTablesClient            network.RouteTablesClient
 	routesClient                 network.RoutesClient
 
@@ -257,6 +258,12 @@ func (c *Config) getArmClient() (*ArmClient, error) {
 	vnc.Sender = autorest.CreateSender(withRequestLogging())
 	client.vnetClient = vnc
 
+	vnpc := network.NewVirtualNetworkPeeringsClient(c.SubscriptionID)
+	setUserAgent(&vnpc.Client)
+	vnpc.Authorizer = spt
+	vnpc.Sender = autorest.CreateSender(withRequestLogging())
+	client.vnetPeeringsClient = vnpc
+
 	rtc := network.NewRouteTablesClient(c.SubscriptionID)
 	setUserAgent(&rtc.Client)
 	rtc.Authorizer = spt

builtin/providers/azurerm/import_arm_virtual_network_peering_test.go

@@ -0,0 +1,34 @@
+package azurerm
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform/helper/acctest"
+	"github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccAzureRMVirtualNetworkPeering_importBasic(t *testing.T) {
+	resourceName := "azurerm_virtual_network_peering.test1"
+
+	ri := acctest.RandInt()
+	config := fmt.Sprintf(testAccAzureRMVirtualNetworkPeering_basic, ri, ri, ri, ri, ri)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testCheckAzureRMVirtualNetworkPeeringDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: config,
+			},
+
+			resource.TestStep{
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"resource_group_name"},
+			},
+		},
+	})
+}

builtin/providers/azurerm/provider.go

@@ -68,6 +68,7 @@ func Provider() terraform.ResourceProvider {
 			"azurerm_virtual_machine":           resourceArmVirtualMachine(),
 			"azurerm_virtual_machine_scale_set": resourceArmVirtualMachineScaleSet(),
 			"azurerm_virtual_network":           resourceArmVirtualNetwork(),
+			"azurerm_virtual_network_peering":   resourceArmVirtualNetworkPeering(),
 
 			// These resources use the Riviera SDK
 			"azurerm_dns_a_record":      resourceArmDnsARecord(),

builtin/providers/azurerm/resource_arm_virtual_network_peering.go

@@ -0,0 +1,182 @@
+package azurerm
+
+import (
+	"fmt"
+	"log"
+	"net/http"
+	"sync"
+
+	"github.com/Azure/azure-sdk-for-go/arm/network"
+	"github.com/hashicorp/terraform/helper/schema"
+)
+
+// peerMutex is used to prevet multiple Peering resources being creaed, updated
+// or deleted at the same time
+var peerMutex = &sync.Mutex{}
+
+func resourceArmVirtualNetworkPeering() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceArmVirtualNetworkPeeringCreate,
+		Read:   resourceArmVirtualNetworkPeeringRead,
+		Update: resourceArmVirtualNetworkPeeringCreate,
+		Delete: resourceArmVirtualNetworkPeeringDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
+
+		Schema: map[string]*schema.Schema{
+			"name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"resource_group_name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"virtual_network_name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"remote_virtual_network_id": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"allow_virtual_network_access": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Computed: true,
+			},
+
+			"allow_forwarded_traffic": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Computed: true,
+			},
+
+			"allow_gateway_transit": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Computed: true,
+			},
+
+			"use_remote_gateways": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Computed: true,
+			},
+		},
+	}
+}
+
+func resourceArmVirtualNetworkPeeringCreate(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).vnetPeeringsClient
+
+	log.Printf("[INFO] preparing arguments for Azure ARM virtual network peering creation.")
+
+	name := d.Get("name").(string)
+	vnetName := d.Get("virtual_network_name").(string)
+	resGroup := d.Get("resource_group_name").(string)
+
+	peer := network.VirtualNetworkPeering{
+		Name:       &name,
+		Properties: getVirtualNetworkPeeringProperties(d),
+	}
+
+	peerMutex.Lock()
+	defer peerMutex.Unlock()
+
+	_, err := client.CreateOrUpdate(resGroup, vnetName, name, peer, make(chan struct{}))
+	if err != nil {
+		return err
+	}
+
+	read, err := client.Get(resGroup, vnetName, name)
+	if err != nil {
+		return err
+	}
+	if read.ID == nil {
+		return fmt.Errorf("Cannot read Virtual Network Peering %s (resource group %s) ID", name, resGroup)
+	}
+
+	d.SetId(*read.ID)
+
+	return resourceArmVirtualNetworkPeeringRead(d, meta)
+}
+
+func resourceArmVirtualNetworkPeeringRead(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).vnetPeeringsClient
+
+	id, err := parseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resGroup := id.ResourceGroup
+	vnetName := id.Path["virtualNetworks"]
+	name := id.Path["virtualNetworkPeerings"]
+
+	resp, err := client.Get(resGroup, vnetName, name)
+	if resp.StatusCode == http.StatusNotFound {
+		d.SetId("")
+		return nil
+	}
+	if err != nil {
+		return fmt.Errorf("Error making Read request on Azure virtual network peering %s: %s", name, err)
+	}
+	peer := *resp.Properties
+
+	// update appropriate values
+	d.Set("name", resp.Name)
+	d.Set("virtual_network_name", vnetName)
+	d.Set("allow_virtual_network_access", peer.AllowVirtualNetworkAccess)
+	d.Set("allow_forwarded_traffic", peer.AllowForwardedTraffic)
+	d.Set("allow_gateway_transit", peer.AllowGatewayTransit)
+	d.Set("use_remote_gateways", peer.UseRemoteGateways)
+	d.Set("remote_virtual_network_id", peer.RemoteVirtualNetwork.ID)
+
+	return nil
+}
+
+func resourceArmVirtualNetworkPeeringDelete(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).vnetPeeringsClient
+
+	id, err := parseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resGroup := id.ResourceGroup
+	vnetName := id.Path["virtualNetworks"]
+	name := id.Path["virtualNetworkPeerings"]
+
+	peerMutex.Lock()
+	defer peerMutex.Unlock()
+
+	_, err = client.Delete(resGroup, vnetName, name, make(chan struct{}))
+
+	return err
+}
+
+func getVirtualNetworkPeeringProperties(d *schema.ResourceData) *network.VirtualNetworkPeeringPropertiesFormat {
+	allowVirtualNetworkAccess := d.Get("allow_virtual_network_access").(bool)
+	allowForwardedTraffic := d.Get("allow_forwarded_traffic").(bool)
+	allowGatewayTransit := d.Get("allow_gateway_transit").(bool)
+	useRemoteGateways := d.Get("use_remote_gateways").(bool)
+	remoteVirtualNetworkID := d.Get("remote_virtual_network_id").(string)
+
+	return &network.VirtualNetworkPeeringPropertiesFormat{
+		AllowVirtualNetworkAccess: &allowVirtualNetworkAccess,
+		AllowForwardedTraffic:     &allowForwardedTraffic,
+		AllowGatewayTransit:       &allowGatewayTransit,
+		UseRemoteGateways:         &useRemoteGateways,
+		RemoteVirtualNetwork: &network.SubResource{
+			ID: &remoteVirtualNetworkID,
+		},
+	}
+}