Skip to content

Commit e21203a

Browse files
committed
Changed sync token to int and use it as id.
1 parent 8accef2 commit e21203a

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

builtin/providers/aws/data_source_aws_ip_ranges.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66
"io/ioutil"
77
"log"
88
"sort"
9+
"strconv"
910
"strings"
10-
"time"
1111

1212
"github.com/hashicorp/go-cleanhttp"
1313
"github.com/hashicorp/terraform/helper/schema"
@@ -50,7 +50,7 @@ func dataSourceAwsIPRanges() *schema.Resource {
5050
Elem: &schema.Schema{Type: schema.TypeString},
5151
},
5252
"sync_token": &schema.Schema{
53-
Type: schema.TypeString,
53+
Type: schema.TypeInt,
5454
Computed: true,
5555
},
5656
},
@@ -62,7 +62,6 @@ func dataSourceAwsIPRangesRead(d *schema.ResourceData, meta interface{}) error {
6262
conn := cleanhttp.DefaultClient()
6363

6464
log.Printf("[DEBUG] Reading IP ranges")
65-
d.SetId(time.Now().UTC().String())
6665

6766
res, err := conn.Get("https://ip-ranges.amazonaws.com/ip-ranges.json")
6867

@@ -88,7 +87,15 @@ func dataSourceAwsIPRangesRead(d *schema.ResourceData, meta interface{}) error {
8887
return fmt.Errorf("Error setting create date: %s", err)
8988
}
9089

91-
if err := d.Set("sync_token", result.SyncToken); err != nil {
90+
syncToken, err := strconv.Atoi(result.SyncToken)
91+
92+
if err != nil {
93+
return fmt.Errorf("Error while converting sync token: %s", err)
94+
}
95+
96+
d.SetId(result.SyncToken)
97+
98+
if err := d.Set("sync_token", syncToken); err != nil {
9299
return fmt.Errorf("Error setting sync token: %s", err)
93100
}
94101

0 commit comments

Comments
 (0)