provider/pagerduty Add delete support to pagerduty_service_integration (hashicorp#10891)

* Vendor update

* Add delete support

* Update documentation

Author: heimweh

builtin/providers/pagerduty/errors.go

@@ -0,0 +1,11 @@
+package pagerduty
+
+import "strings"
+
+func isNotFound(err error) bool {
+	if strings.Contains(err.Error(), "Failed call API endpoint. HTTP response code: 404") {
+		return true
+	}
+
+	return false
+}

builtin/providers/pagerduty/resource_pagerduty_service_integration.go

@@ -12,8 +12,6 @@ func resourcePagerDutyServiceIntegration() *schema.Resource {
 		Create: resourcePagerDutyServiceIntegrationCreate,
 		Read:   resourcePagerDutyServiceIntegrationRead,
 		Update: resourcePagerDutyServiceIntegrationUpdate,
-		// NOTE: It's currently not possible to delete integrations via the API.
-		// Therefore it needs to be manually removed from the Web UI.
 		Delete: resourcePagerDutyServiceIntegrationDelete,
 		Schema: map[string]*schema.Schema{
 			"name": {
@@ -123,6 +121,10 @@ func resourcePagerDutyServiceIntegrationRead(d *schema.ResourceData, meta interf
 	serviceIntegration, err := client.GetIntegration(service, d.Id(), *o)
 
 	if err != nil {
+		if isNotFound(err) {
+			d.SetId("")
+			return nil
+		}
 		return err
 	}
 
@@ -153,8 +155,20 @@ func resourcePagerDutyServiceIntegrationUpdate(d *schema.ResourceData, meta inte
 }
 
 func resourcePagerDutyServiceIntegrationDelete(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*pagerduty.Client)
+
+	service := d.Get("service").(string)
+
 	log.Printf("[INFO] Removing PagerDuty service integration %s", d.Id())
 
+	if err := client.DeleteIntegration(service, d.Id()); err != nil {
+		if isNotFound(err) {
+			d.SetId("")
+			return nil
+		}
+		return err
+	}
+
 	d.SetId("")
 
 	return nil

vendor/github.com/PagerDuty/go-pagerduty/incident.go

@@ -333,10 +333,10 @@
 			"revisionTime": "2016-11-03T18:56:17Z"
 		},
 		{
-			"checksumSHA1": "yAhUY67XCnf+0jpIsQ53lirk+GM=",
+			"checksumSHA1": "wzzdybMOEWsQ/crdkpTLneeob2U=",
 			"path": "github.com/PagerDuty/go-pagerduty",
-			"revision": "b98d93d395cd13b0438ad908b5f7c608f1f74c38",
-			"revisionTime": "2016-12-16T21:25:03Z"
+			"revision": "317bca1364fc322f4d6f8eeb276e931b6667b43b",
+			"revisionTime": "2016-12-20T22:05:08Z"
 		},
 		{
 			"path": "github.com/Unknwon/com",

vendor/github.com/PagerDuty/go-pagerduty/log_entry.go

@@ -10,9 +10,6 @@ description: |-
 
 A [service integration](https://v2.developer.pagerduty.com/v2/page/api-reference#!/Services/post_services_id_integrations) is an integration that belongs to a service.
 
-`Note`: A service integration `cannot` be deleted via Terraform nor the PagerDuty API so if you remove a service integration, be sure to remove it from the PagerDuty Web UI afterwards. However, if you delete the `service` attached to the `integration`, the integration will be removed.
-
-
 ## Example Usage
 
 ```