providers/mailgun: smtp_password is required

Author: pearkes

builtin/providers/mailgun/resource_mailgun_domain.go

@@ -32,7 +32,7 @@ func resourceMailgunDomain() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 				ForceNew: true,
-				Optional: true,
+				Required: true,
 			},
 
 			"smtp_login": &schema.Schema{

builtin/providers/mailgun/resource_mailgun_domain_test.go

@@ -66,7 +66,7 @@ func testAccCheckMailgunDomainAttributes(Domain *mailgun.Domain) resource.TestCh
 		}
 
 		if Domain.Wildcard != true {
-			return fmt.Errorf("Bad wildcard: %s", Domain.SpamAction)
+			return fmt.Errorf("Bad wildcard: %s", Domain.Wildcard)
 		}
 
 		if Domain.SmtpPassword != "foobar" {

website/source/docs/providers/mailgun/r/domain.html.markdown

@@ -13,8 +13,9 @@ create and manage applications on Mailgun.
 
 ```
 # Create a new mailgun domain
-resource "mailgun_app" "default" {
+resource "mailgun_domain" "default" {
     name = "test.example.com"
+    smtp_password = "foobar"
 }
 
 # Create SMTP Credentials
@@ -30,7 +31,7 @@ resource "mailgun_domain" "default" {
 The following arguments are supported:
 
 * `name` - (Required) The domain to add to Mailgun
-* `smtp_password` - (Optional) Password for SMTP authentication
+* `smtp_password` - (Required) Password for SMTP authentication
 * `spam_action` - (Optional) `disabled` or `tag` Disable, no spam
     filtering will occur for inbound messages. Tag, messages
     will be tagged wtih a spam header.