Skip to content

Commit 78471d2

Browse files
committed
providers/cloudflare: tests passing, compiles
1 parent e406659 commit 78471d2

3 files changed

Lines changed: 26 additions & 23 deletions

File tree

builtin/providers/cloudflare/resource_cloudflare_record.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import (
1111
)
1212

1313
func resource_cloudflare_record_create(
14-
s *terraform.ResourceState,
14+
s *terraform.InstanceState,
1515
d *terraform.ResourceDiff,
16-
meta interface{}) (*terraform.ResourceState, error) {
16+
meta interface{}) (*terraform.InstanceState, error) {
1717
p := meta.(*ResourceProvider)
1818
client := p.client
1919

@@ -51,9 +51,9 @@ func resource_cloudflare_record_create(
5151
}
5252

5353
func resource_cloudflare_record_update(
54-
s *terraform.ResourceState,
54+
s *terraform.InstanceState,
5555
d *terraform.ResourceDiff,
56-
meta interface{}) (*terraform.ResourceState, error) {
56+
meta interface{}) (*terraform.InstanceState, error) {
5757
p := meta.(*ResourceProvider)
5858
client := p.client
5959
rs := s.MergeDiff(d)
@@ -86,7 +86,7 @@ func resource_cloudflare_record_update(
8686
}
8787

8888
func resource_cloudflare_record_destroy(
89-
s *terraform.ResourceState,
89+
s *terraform.InstanceState,
9090
meta interface{}) error {
9191
p := meta.(*ResourceProvider)
9292
client := p.client
@@ -103,8 +103,8 @@ func resource_cloudflare_record_destroy(
103103
}
104104

105105
func resource_cloudflare_record_refresh(
106-
s *terraform.ResourceState,
107-
meta interface{}) (*terraform.ResourceState, error) {
106+
s *terraform.InstanceState,
107+
meta interface{}) (*terraform.InstanceState, error) {
108108
p := meta.(*ResourceProvider)
109109
client := p.client
110110

@@ -117,7 +117,7 @@ func resource_cloudflare_record_refresh(
117117
}
118118

119119
func resource_cloudflare_record_diff(
120-
s *terraform.ResourceState,
120+
s *terraform.InstanceState,
121121
c *terraform.ResourceConfig,
122122
meta interface{}) (*terraform.ResourceDiff, error) {
123123

@@ -144,8 +144,8 @@ func resource_cloudflare_record_diff(
144144
}
145145

146146
func resource_cloudflare_record_update_state(
147-
s *terraform.ResourceState,
148-
rec *cloudflare.Record) (*terraform.ResourceState, error) {
147+
s *terraform.InstanceState,
148+
rec *cloudflare.Record) (*terraform.InstanceState, error) {
149149

150150
s.Attributes["name"] = rec.Name
151151
s.Attributes["value"] = rec.Value

builtin/providers/cloudflare/resource_cloudflare_record_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ func TestAccCLOudflareRecord_Updated(t *testing.T) {
7878
func testAccCheckCLOudflareRecordDestroy(s *terraform.State) error {
7979
client := testAccProvider.client
8080

81-
for _, rs := range s.Resources {
81+
for _, rs := range s.RootModule().Resources {
8282
if rs.Type != "cloudflare_record" {
8383
continue
8484
}
8585

86-
_, err := client.RetrieveRecord(rs.Attributes["domain"], rs.ID)
86+
_, err := client.RetrieveRecord(rs.Primary.Attributes["domain"], rs.Primary.ID)
8787

8888
if err == nil {
8989
return fmt.Errorf("Record still exists")
@@ -117,25 +117,25 @@ func testAccCheckCLOudflareRecordAttributesUpdated(record *cloudflare.Record) re
117117

118118
func testAccCheckCLOudflareRecordExists(n string, record *cloudflare.Record) resource.TestCheckFunc {
119119
return func(s *terraform.State) error {
120-
rs, ok := s.Resources[n]
120+
rs, ok := s.RootModule().Resources[n]
121121

122122
if !ok {
123123
return fmt.Errorf("Not found: %s", n)
124124
}
125125

126-
if rs.ID == "" {
126+
if rs.Primary.ID == "" {
127127
return fmt.Errorf("No Record ID is set")
128128
}
129129

130130
client := testAccProvider.client
131131

132-
foundRecord, err := client.RetrieveRecord(rs.Attributes["domain"], rs.ID)
132+
foundRecord, err := client.RetrieveRecord(rs.Primary.Attributes["domain"], rs.Primary.ID)
133133

134134
if err != nil {
135135
return err
136136
}
137137

138-
if foundRecord.Id != rs.ID {
138+
if foundRecord.Id != rs.Primary.ID {
139139
return fmt.Errorf("Record not found")
140140
}
141141

builtin/providers/cloudflare/resource_provider.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,23 @@ func (p *ResourceProvider) Configure(c *terraform.ResourceConfig) error {
4747
}
4848

4949
func (p *ResourceProvider) Apply(
50-
s *terraform.ResourceState,
51-
d *terraform.ResourceDiff) (*terraform.ResourceState, error) {
52-
return resourceMap.Apply(s, d, p)
50+
info *terraform.InstanceInfo,
51+
s *terraform.InstanceState,
52+
d *terraform.ResourceDiff) (*terraform.InstanceState, error) {
53+
return resourceMap.Apply(info, s, d, p)
5354
}
5455

5556
func (p *ResourceProvider) Diff(
56-
s *terraform.ResourceState,
57+
info *terraform.InstanceInfo,
58+
s *terraform.InstanceState,
5759
c *terraform.ResourceConfig) (*terraform.ResourceDiff, error) {
58-
return resourceMap.Diff(s, c, p)
60+
return resourceMap.Diff(info, s, c, p)
5961
}
6062

6163
func (p *ResourceProvider) Refresh(
62-
s *terraform.ResourceState) (*terraform.ResourceState, error) {
63-
return resourceMap.Refresh(s, p)
64+
info *terraform.InstanceInfo,
65+
s *terraform.InstanceState) (*terraform.InstanceState, error) {
66+
return resourceMap.Refresh(info, s, p)
6467
}
6568

6669
func (p *ResourceProvider) Resources() []terraform.ResourceType {

0 commit comments

Comments
 (0)