provider/azurerm: add servicebus_subscription resource

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMServiceBusSubscription -timeout 120m
=== RUN   TestAccAzureRMServiceBusSubscription_importBasic
--- PASS: TestAccAzureRMServiceBusSubscription_importBasic (339.00s)
=== RUN   TestAccAzureRMServiceBusSubscription_basic
--- PASS: TestAccAzureRMServiceBusSubscription_basic (328.47s)
=== RUN   TestAccAzureRMServiceBusSubscription_update
--- PASS: TestAccAzureRMServiceBusSubscription_update (368.95s)
=== RUN   TestAccAzureRMServiceBusSubscription_updateRequiresSession
--- PASS: TestAccAzureRMServiceBusSubscription_updateRequiresSession (348.47s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	1384.966s

Author: Peter McAtominey

builtin/providers/azurerm/config.go

@@ -68,8 +68,9 @@ type ArmClient struct {
 	trafficManagerProfilesClient  trafficmanager.ProfilesClient
 	trafficManagerEndpointsClient trafficmanager.EndpointsClient
 
-	serviceBusNamespacesClient servicebus.NamespacesClient
-	serviceBusTopicsClient     servicebus.TopicsClient
+	serviceBusNamespacesClient    servicebus.NamespacesClient
+	serviceBusTopicsClient        servicebus.TopicsClient
+	serviceBusSubscriptionsClient servicebus.SubscriptionsClient
 }
 
 func withRequestLogging() autorest.SendDecorator {
@@ -359,6 +360,12 @@ func (c *Config) getArmClient() (*ArmClient, error) {
 	sbtc.Sender = autorest.CreateSender(withRequestLogging())
 	client.serviceBusTopicsClient = sbtc
 
+	sbsc := servicebus.NewSubscriptionsClient(c.SubscriptionID)
+	setUserAgent(&sbsc.Client)
+	sbsc.Authorizer = spt
+	sbsc.Sender = autorest.CreateSender(withRequestLogging())
+	client.serviceBusSubscriptionsClient = sbsc
+
 	return &client, nil
 }
 

builtin/providers/azurerm/import_arm_servicebus_subscription_test.go

@@ -0,0 +1,33 @@
+package azurerm
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform/helper/acctest"
+	"github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccAzureRMServiceBusSubscription_importBasic(t *testing.T) {
+	resourceName := "azurerm_servicebus_subscription.test"
+
+	ri := acctest.RandInt()
+	config := fmt.Sprintf(testAccAzureRMServiceBusSubscription_basic, ri, ri, ri, ri)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testCheckAzureRMServiceBusSubscriptionDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: config,
+			},
+
+			resource.TestStep{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}

builtin/providers/azurerm/provider.go

@@ -57,6 +57,7 @@ func Provider() terraform.ResourceProvider {
 			"azurerm_route":                     resourceArmRoute(),
 			"azurerm_route_table":               resourceArmRouteTable(),
 			"azurerm_servicebus_namespace":      resourceArmServiceBusNamespace(),
+			"azurerm_servicebus_subscription":   resourceArmServiceBusSubscription(),
 			"azurerm_servicebus_topic":          resourceArmServiceBusTopic(),
 			"azurerm_storage_account":           resourceArmStorageAccount(),
 			"azurerm_storage_blob":              resourceArmStorageBlob(),

builtin/providers/azurerm/resource_arm_servicebus_subscription.go

@@ -0,0 +1,212 @@
+package azurerm
+
+import (
+	"fmt"
+	"log"
+	"net/http"
+
+	"github.com/Azure/azure-sdk-for-go/arm/servicebus"
+	"github.com/hashicorp/terraform/helper/schema"
+)
+
+func resourceArmServiceBusSubscription() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceArmServiceBusSubscriptionCreate,
+		Read:   resourceArmServiceBusSubscriptionRead,
+		Update: resourceArmServiceBusSubscriptionCreate,
+		Delete: resourceArmServiceBusSubscriptionDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
+
+		Schema: map[string]*schema.Schema{
+			"name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"namespace_name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"topic_name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"location": {
+				Type:      schema.TypeString,
+				Required:  true,
+				ForceNew:  true,
+				StateFunc: azureRMNormalizeLocation,
+			},
+
+			"resource_group_name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"auto_delete_on_idle": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
+			"default_message_ttl": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
+			"lock_duration": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
+			"dead_lettering_on_filter_evaluation_exceptions": {
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
+
+			"dead_lettering_on_message_expiration": {
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
+
+			"enable_batched_operations": {
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
+
+			"max_delivery_count": {
+				Type:     schema.TypeInt,
+				Required: true,
+			},
+
+			"requires_session": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				// cannot be modified
+				ForceNew: true,
+			},
+		},
+	}
+}
+
+func resourceArmServiceBusSubscriptionCreate(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).serviceBusSubscriptionsClient
+	log.Printf("[INFO] preparing arguments for Azure ARM ServiceBus Subscription creation.")
+
+	name := d.Get("name").(string)
+	topicName := d.Get("topic_name").(string)
+	namespaceName := d.Get("namespace_name").(string)
+	location := d.Get("location").(string)
+	resGroup := d.Get("resource_group_name").(string)
+
+	parameters := servicebus.SubscriptionCreateOrUpdateParameters{
+		Location:   &location,
+		Properties: &servicebus.SubscriptionProperties{},
+	}
+
+	if autoDeleteOnIdle := d.Get("auto_delete_on_idle").(string); autoDeleteOnIdle != "" {
+		parameters.Properties.AutoDeleteOnIdle = &autoDeleteOnIdle
+	}
+
+	if lockDuration := d.Get("lock_duration").(string); lockDuration != "" {
+		parameters.Properties.LockDuration = &lockDuration
+	}
+
+	deadLetteringFilterExceptions := d.Get("dead_lettering_on_filter_evaluation_exceptions").(bool)
+	deadLetteringExpiration := d.Get("dead_lettering_on_message_expiration").(bool)
+	enableBatchedOps := d.Get("enable_batched_operations").(bool)
+	maxDeliveryCount := int32(d.Get("max_delivery_count").(int))
+	requiresSession := d.Get("requires_session").(bool)
+
+	parameters.Properties.DeadLetteringOnFilterEvaluationExceptions = &deadLetteringFilterExceptions
+	parameters.Properties.DeadLetteringOnMessageExpiration = &deadLetteringExpiration
+	parameters.Properties.EnableBatchedOperations = &enableBatchedOps
+	parameters.Properties.MaxDeliveryCount = &maxDeliveryCount
+	parameters.Properties.RequiresSession = &requiresSession
+
+	_, err := client.CreateOrUpdate(resGroup, namespaceName, topicName, name, parameters)
+	if err != nil {
+		return err
+	}
+
+	read, err := client.Get(resGroup, namespaceName, topicName, name)
+	if err != nil {
+		return err
+	}
+	if read.ID == nil {
+		return fmt.Errorf("Cannot read ServiceBus Subscription %s (resource group %s) ID", name, resGroup)
+	}
+
+	d.SetId(*read.ID)
+
+	return resourceArmServiceBusSubscriptionRead(d, meta)
+}
+
+func resourceArmServiceBusSubscriptionRead(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).serviceBusSubscriptionsClient
+
+	id, err := parseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resGroup := id.ResourceGroup
+	namespaceName := id.Path["namespaces"]
+	topicName := id.Path["topics"]
+	name := id.Path["subscriptions"]
+
+	log.Printf("[INFO] subscriptionID: %s, args: %s, %s, %s, %s", d.Id(), resGroup, namespaceName, topicName, name)
+
+	resp, err := client.Get(resGroup, namespaceName, topicName, name)
+	if err != nil {
+		return fmt.Errorf("Error making Read request on Azure ServiceBus Subscription %s: %s", name, err)
+	}
+	if resp.StatusCode == http.StatusNotFound {
+		d.SetId("")
+		return nil
+	}
+
+	d.Set("name", resp.Name)
+	d.Set("resource_group_name", resGroup)
+	d.Set("namespace_name", namespaceName)
+	d.Set("topic_name", topicName)
+	d.Set("location", azureRMNormalizeLocation(*resp.Location))
+
+	props := resp.Properties
+	d.Set("auto_delete_on_idle", props.AutoDeleteOnIdle)
+	d.Set("default_message_ttl", props.DefaultMessageTimeToLive)
+	d.Set("lock_duration", props.LockDuration)
+	d.Set("dead_lettering_on_filter_evaluation_exceptions", props.DeadLetteringOnFilterEvaluationExceptions)
+	d.Set("dead_lettering_on_message_expiration", props.DeadLetteringOnMessageExpiration)
+	d.Set("enable_batched_operations", props.EnableBatchedOperations)
+	d.Set("max_delivery_count", int(*props.MaxDeliveryCount))
+	d.Set("requires_session", props.RequiresSession)
+
+	return nil
+}
+
+func resourceArmServiceBusSubscriptionDelete(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).serviceBusSubscriptionsClient
+
+	id, err := parseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resGroup := id.ResourceGroup
+	namespaceName := id.Path["namespaces"]
+	topicName := id.Path["topics"]
+	name := id.Path["subscriptions"]
+
+	_, err = client.Delete(resGroup, namespaceName, topicName, name)
+
+	return err
+}