Added LoadBalancer support for Cloudstack Provider

PR is complete with docs and tests

Author: jedekocom

builtin/providers/cloudstack/provider.go

@@ -46,6 +46,7 @@ func Provider() terraform.ResourceProvider {
 			"cloudstack_firewall":             resourceCloudStackFirewall(),
 			"cloudstack_instance":             resourceCloudStackInstance(),
 			"cloudstack_ipaddress":            resourceCloudStackIPAddress(),
+			"cloudstack_loadbalancer_rule":    resourceCloudStackLoadBalancerRule(),
 			"cloudstack_network":              resourceCloudStackNetwork(),
 			"cloudstack_network_acl":          resourceCloudStackNetworkACL(),
 			"cloudstack_network_acl_rule":     resourceCloudStackNetworkACLRule(),

builtin/providers/cloudstack/resource_cloudstack_loadbalancer.go

@@ -0,0 +1,236 @@
+package cloudstack
+
+import (
+	"fmt"
+	"log"
+	"strings"
+
+	"github.com/hashicorp/terraform/helper/schema"
+	"github.com/xanzy/go-cloudstack/cloudstack"
+)
+
+func resourceCloudStackLoadBalancerRule() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceCloudStackLoadBalancerRuleCreate,
+		Read:   resourceCloudStackLoadBalancerRuleRead,
+		Update: resourceCloudStackLoadBalancerRuleUpdate,
+		Delete: resourceCloudStackLoadBalancerRuleDelete,
+
+		Schema: map[string]*schema.Schema{
+			"name": &schema.Schema{
+				Type:     schema.TypeString,
+				Required: true,
+			},
+
+			"description": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
+			"ipaddress": &schema.Schema{
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"network": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,
+				ForceNew: true,
+			},
+
+			"algorithm": &schema.Schema{
+				Type:     schema.TypeString,
+				Required: true,
+			},
+
+			"private_port": &schema.Schema{
+				Type:     schema.TypeInt,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"public_port": &schema.Schema{
+				Type:     schema.TypeInt,
+				Required: true,
+				ForceNew: true,
+			},
+
+			"members": &schema.Schema{
+				Type:     schema.TypeList,
+				Required: true,
+				ForceNew: true,
+				Elem:     &schema.Schema{Type: schema.TypeString},
+			},
+		},
+	}
+}
+
+func resourceCloudStackLoadBalancerRuleCreate(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+	d.Partial(true)
+
+	// Create a new parameter struct
+	p := cs.LoadBalancer.NewCreateLoadBalancerRuleParams(
+		d.Get("algorithm").(string),
+		d.Get("name").(string),
+		d.Get("private_port").(int),
+		d.Get("public_port").(int),
+	)
+
+	// Set the description
+	if description, ok := d.GetOk("description"); ok {
+		p.SetDescription(description.(string))
+	} else {
+		p.SetDescription(d.Get("name").(string))
+	}
+
+	// Retrieve the network and the UUID
+	if network, ok := d.GetOk("network"); ok {
+		networkid, e := retrieveUUID(cs, "network", network.(string))
+		if e != nil {
+			return e.Error()
+		}
+
+		// Set the default network ID
+		p.SetNetworkid(networkid)
+	}
+
+	// Retrieve the ipaddress UUID
+	ipaddressid, e := retrieveUUID(cs, "ipaddress", d.Get("ipaddress").(string))
+	if e != nil {
+		return e.Error()
+	}
+	p.SetPublicipid(ipaddressid)
+
+	// Create the load balancer rule
+	r, err := cs.LoadBalancer.CreateLoadBalancerRule(p)
+	if err != nil {
+		return err
+	}
+
+	// Set the load balancer rule UUID and set partials
+	d.SetId(r.Id)
+	d.SetPartial("name")
+	d.SetPartial("description")
+	d.SetPartial("ipaddress")
+	d.SetPartial("network")
+	d.SetPartial("algorithm")
+	d.SetPartial("private_port")
+	d.SetPartial("public_port")
+
+	// Create a new parameter struct
+	ap := cs.LoadBalancer.NewAssignToLoadBalancerRuleParams(r.Id)
+
+	var mbs []string
+	for _, id := range d.Get("members").([]interface{}) {
+		mbs = append(mbs, id.(string))
+	}
+
+	ap.SetVirtualmachineids(mbs)
+
+	_, err = cs.LoadBalancer.AssignToLoadBalancerRule(ap)
+	if err != nil {
+		return err
+	}
+
+	d.SetPartial("members")
+
+	d.Partial(false)
+	return resourceCloudStackLoadBalancerRuleRead(d, meta)
+}
+
+func resourceCloudStackLoadBalancerRuleRead(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	// Get the load balancer details
+	lb, count, err := cs.LoadBalancer.GetLoadBalancerRuleByID(d.Id())
+	if err != nil {
+		if count == 0 {
+			log.Printf("[DEBUG] Load balancer rule %s does no longer exist", d.Get("name").(string))
+			d.SetId("")
+			return nil
+		}
+
+		return err
+	}
+
+	d.Set("algorithm", lb.Algorithm)
+	d.Set("public_port", lb.Publicport)
+	d.Set("private_port", lb.Privateport)
+
+	// Get the network details
+	network, _, err := cs.Network.GetNetworkByID(lb.Networkid)
+	if err != nil {
+		return err
+	}
+
+	setValueOrUUID(d, "ipaddress", lb.Publicip, lb.Publicipid)
+	setValueOrUUID(d, "network", network.Name, lb.Networkid)
+
+	return nil
+}
+
+func resourceCloudStackLoadBalancerRuleUpdate(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	if d.HasChange("name") || d.HasChange("description") || d.HasChange("algorithm") {
+		name := d.Get("name").(string)
+
+		// Create new parameter struct
+		p := cs.LoadBalancer.NewUpdateLoadBalancerRuleParams(d.Id())
+
+		if d.HasChange("name") {
+			log.Printf("[DEBUG] Name has changed for load balancer rule %s, starting update", name)
+
+			p.SetName(name)
+		}
+
+		if d.HasChange("description") {
+			log.Printf(
+				"[DEBUG] Description has changed for load balancer rule %s, starting update", name)
+
+			p.SetDescription(d.Get("description").(string))
+		}
+
+		if d.HasChange("algorithm") {
+			algorithm := d.Get("algorithm").(string)
+
+			log.Printf(
+				"[DEBUG] Algorithm has changed to %s for load balancer rule %s, starting update",
+				algorithm,
+				name,
+			)
+
+			// Set the new Algorithm
+			p.SetAlgorithm(algorithm)
+		}
+
+		_, err := cs.LoadBalancer.UpdateLoadBalancerRule(p)
+		if err != nil {
+			return fmt.Errorf(
+				"Error updating load balancer rule %s", name)
+		}
+	}
+	return resourceCloudStackLoadBalancerRuleRead(d, meta)
+}
+
+func resourceCloudStackLoadBalancerRuleDelete(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	// Create a new parameter struct
+	p := cs.LoadBalancer.NewDeleteLoadBalancerRuleParams(d.Id())
+
+	log.Printf("[INFO] Deleting load balancer rule: %s", d.Get("name").(string))
+	if _, err := cs.LoadBalancer.DeleteLoadBalancerRule(p); err != nil {
+		// This is a very poor way to be told the UUID does no longer exist :(
+		if !strings.Contains(err.Error(), fmt.Sprintf(
+			"Invalid parameter id value=%s due to incorrect long value format, "+
+				"or entity does not exist", d.Id())) {
+			return err
+		}
+	}
+
+	return nil
+}