provider/datadog 9869: Validate credentials when initialising client. (hashicorp#10567)

* provider/datadog 9869: Validate credentials when initialising client.

* provider/datadog Pull in new version of go-datadog-api.

* provider/datadog Update testAccCheckDatadogMonitorConfigNoThresholds test config.

Author: ojongerius

builtin/providers/datadog/config.go

@@ -13,11 +13,10 @@ type Config struct {
 }
 
 // Client returns a new Datadog client.
-func (c *Config) Client() (*datadog.Client, error) {
+func (c *Config) Client() *datadog.Client {
 
 	client := datadog.NewClient(c.APIKey, c.APPKey)
-
 	log.Printf("[INFO] Datadog Client configured ")
 
-	return client, nil
+	return client
 }

builtin/providers/datadog/provider.go

@@ -3,6 +3,7 @@ package datadog
 import (
 	"log"
 
+	"errors"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/terraform"
 )
@@ -39,5 +40,17 @@ func providerConfigure(d *schema.ResourceData) (interface{}, error) {
 	}
 
 	log.Println("[INFO] Initializing Datadog client")
-	return config.Client()
+	client := config.Client()
+
+	ok, err := client.Validate()
+
+	if err != nil {
+		return client, err
+	}
+
+	if ok == false {
+		return client, errors.New(`No valid credential sources found for Datadog Provider. Please see https://terraform.io/docs/providers/datadog/index.html for more information on providing credentials for the Datadog Provider`)
+	}
+
+	return client, nil
 }

builtin/providers/datadog/resource_datadog_monitor_test.go

@@ -78,9 +78,9 @@ func TestAccDatadogMonitor_BasicNoTreshold(t *testing.T) {
 					resource.TestCheckResourceAttr(
 						"datadog_monitor.foo", "locked", "false"),
 					resource.TestCheckResourceAttr(
-						"datadog_monitor.foo", "tags.foo", "bar"),
+						"datadog_monitor.foo", "tags.0", "foo:bar"),
 					resource.TestCheckResourceAttr(
-						"datadog_monitor.foo", "tags.bar", "baz"),
+						"datadog_monitor.foo", "tags.1", "bar:baz"),
 				),
 			},
 		},
@@ -305,10 +305,7 @@ resource "datadog_monitor" "foo" {
   include_tags = true
   require_full_window = true
   locked = false
-  tags {
-	"foo" = "bar"
-	"bar" = "baz"
-  }
+  tags = ["foo:bar", "bar:baz"]
 }
 `