Skip to content

Commit 0d895ff

Browse files
committed
provider/aws: mention us-east-1 in ECR docs and tests
ECR is only available in us-east-1 for now. Also added missing sidebar links for ECR resources. /cc @nextrevision
1 parent 4d74bc7 commit 0d895ff

5 files changed

Lines changed: 32 additions & 2 deletions

File tree

builtin/providers/aws/resource_aws_ecr_repository_policy_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@ func testAccCheckAWSEcrRepositoryPolicyExists(name string) resource.TestCheckFun
6262
}
6363

6464
var testAccAWSEcrRepositoryPolicy = `
65+
# ECR initially only available in us-east-1
66+
# https://aws.amazon.com/blogs/aws/ec2-container-registry-now-generally-available/
67+
provider "aws" {
68+
region = "us-east-1"
69+
}
6570
resource "aws_ecr_repository" "foo" {
6671
name = "bar"
6772
}

builtin/providers/aws/resource_aws_ecr_repository_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ func testAccCheckAWSEcrRepositoryExists(name string) resource.TestCheckFunc {
7171
}
7272

7373
var testAccAWSEcrRepository = `
74+
# ECR initially only available in us-east-1
75+
# https://aws.amazon.com/blogs/aws/ec2-container-registry-now-generally-available/
76+
provider "aws" {
77+
region = "us-east-1"
78+
}
7479
resource "aws_ecr_repository" "default" {
7580
name = "foo-repository-terraform"
7681
}

website/source/docs/providers/aws/r/ecr_repository.html.markdown

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,18 @@ layout: "aws"
33
page_title: "AWS: aws_ecr_repository"
44
sidebar_current: "docs-aws-resource-ecr-repository"
55
description: |-
6-
Provides an ECR Repository.
6+
Provides an EC2 Container Registry Repository.
77
---
88

99
# aws\_ecr\_repository
1010

11-
Provides an ECR repository.
11+
Provides an EC2 Container Registry Repository.
12+
13+
~> **NOTE on ECR Availability**: The EC2 Container Registry has an [initial
14+
launch region of
15+
`us-east-1`](https://aws.amazon.com/blogs/aws/ec2-container-registry-now-generally-available/).
16+
As more regions become available, they will be listed [in the AWS
17+
Docs](https://docs.aws.amazon.com/general/latest/gr/rande.html#ecr_region)
1218

1319
## Example Usage
1420

website/source/docs/providers/aws/r/ecr_repository_policy.html.markdown

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ Provides an ECR repository policy.
1212

1313
Note that currently only one policy may be applied to a repository.
1414

15+
~> **NOTE on ECR Availability**: The EC2 Container Registry has an [initial
16+
launch region of
17+
`us-east-1`](https://aws.amazon.com/blogs/aws/ec2-container-registry-now-generally-available/).
18+
As more regions become available, they will be listed [in the AWS
19+
Docs](https://docs.aws.amazon.com/general/latest/gr/rande.html#ecr_region)
20+
1521
## Example Usage
1622

1723
```

website/source/layouts/aws.erb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,14 @@
193193
<a href="/docs/providers/aws/r/ecs_task_definition.html">aws_ecs_task_definition</a>
194194
</li>
195195

196+
<li<%= sidebar_current("docs-aws-resource-ecr-repository") %>>
197+
<a href="/docs/providers/aws/r/ecr_repository.html">aws_ecr_repository</a>
198+
</li>
199+
200+
<li<%= sidebar_current("docs-aws-resource-ecr-repository-policy") %>>
201+
<a href="/docs/providers/aws/r/ecr_repository_policy.html">aws_ecr_repository_policy</a>
202+
</li>
203+
196204
</ul>
197205
</li>
198206

0 commit comments

Comments
 (0)