make the default environment immutable

Author: sdelano

chef-server-api/app/controllers/environments.rb

@@ -60,6 +60,7 @@ def create
 
   # PUT /environments/:id
   def update
+    raise Forbidden if params[:id] == "_default"
     begin
       env = Chef::Environment.cdb_load(params[:id])
     rescue Chef::Exceptions::CouchDBNotFound
@@ -75,6 +76,7 @@ def update
 
   # DELETE /environments/:id
   def destroy
+    raise Forbidden if params[:id] == "_default"
     begin
       env = Chef::Environment.cdb_load(params[:id])
     rescue Chef::Exceptions::CouchDBNotFound

features/api/environments/delete_environment_api.feature

@@ -26,3 +26,13 @@ Feature: Delete environments via the REST API
       And an 'environment' named 'cucumber' exists
      When I 'DELETE' the path '/environments/cucumber'
      Then I should get a '403 "Forbidden"' exception
+
+  Scenario Outline: Delete the '_default' environment
+    Given I am <user_type>
+     When I 'DELETE' the path '/environments/_default'
+     Then I should get a '403 "Forbidden"' exception
+
+  Examples:
+    | user_type        |
+    | an administrator |
+    | a non-admin      |

features/api/environments/update_environment_api.feature

@@ -38,3 +38,14 @@ Feature: Update an environment via the REST API
       And sending the method 'description' to the 'environment' with 'This will not work'
      When I 'PUT' the 'environment' to the path '/environments/cucumber'
      Then I should get a '403 "Forbidden"' exception
+
+  Scenario Outline: Update the '_default' environment
+    Given I am <user_type>
+      And an 'environment' named 'cucumber'
+     When I 'PUT' the 'environment' to the path '/environments/_default'
+     Then I should get a '403 "Forbidden"' exception
+  
+  Examples:
+    | user_type        |
+    | an administrator |
+    | a non-admin      |