internal callbacks after creating/deleting releases

Author: danielsdeleo

chef/lib/chef/provider/deploy.rb

@@ -146,6 +146,7 @@ def cleanup!
         all_releases[0..-6].each do |old_release|
           Chef::Log.info "Removing old release #{old_release}"
           FileUtils.rm_rf(old_release)
+          release_deleted(old_release)
         end
       end
 
@@ -162,6 +163,7 @@ def copy_cached_repo
         Chef::Log.info "copying the cached checkout to #{release_path}"
         FileUtils.mkdir_p(@new_resource.deploy_to + "/releases")
         FileUtils.cp_r(@new_resource.destination, release_path, :preserve => true)
+        release_created
       end
 
       def enforce_ownership
@@ -209,6 +211,20 @@ def purge_tempfiles_from_current_release
 
       protected
 
+      # Internal callback, called after copy_cached_repo.
+      # Override if you need to keep state externally.
+      def release_created
+      end
+      
+      # Internal callback, called during cleanup! for each old release removed.
+      # Override if you need to keep state externally.
+      def release_deleted(release_path)
+      end
+      
+      def release_slug
+        raise Chef::Exceptions::Override, "You must override release_slug in #{self.to_s}"
+      end
+      
       def install_gems
         gems_collection = Chef::ResourceCollection.new
         gem_packages.each { |rbgem| gems_collection << rbgem }
@@ -228,10 +244,6 @@ def gem_packages
         end
       end
 
-      def release_slug
-        raise Chef::Exceptions::Override, "You must override release_slug in #{self.to_s}"
-      end
-      
       def run_options(run_opts={})
         run_opts[:user] = @new_resource.user if @new_resource.user
         run_opts[:group] = @new_resource.group if @new_resource.group

chef/spec/unit/provider/deploy_spec.rb

@@ -124,6 +124,12 @@
     @provider.copy_cached_repo
   end
 
+  it "calls the internal callback :release_created when copying the cached repo" do
+    FileUtils.stub!(:mkdir_p)
+    FileUtils.stub!(:cp_r)
+    @provider.should_receive(:release_created)
+    @provider.copy_cached_repo
+  end
 
   it "chowns the whole release dir to user and group specified in the resource" do
     @resource.user "foo"
@@ -235,6 +241,16 @@
     @provider.cleanup!
   end
 
+  it "fires a callback for :release_deleted when deleting an old release" do
+    all_releases = ["/my/deploy/dir/20040815162342", "/my/deploy/dir/20040700000000", 
+                    "/my/deploy/dir/20040600000000", "/my/deploy/dir/20040500000000",
+                    "/my/deploy/dir/20040400000000", "/my/deploy/dir/20040300000000"].sort!
+    @provider.stub!(:all_releases).and_return(all_releases)
+    FileUtils.stub!(:rm_rf)
+    @provider.should_receive(:release_deleted).with("/my/deploy/dir/20040300000000")
+    @provider.cleanup!
+  end
+  
   it "puts resource.to_hash in @configuration for backwards compat with capistano-esque deploy hooks" do
     @provider.instance_variable_get(:@configuration).should == @resource.to_hash
   end