[CHEF-2178] don't scrub the .rb extension from site-plugins now

Author: danielsdeleo

chef/lib/chef/knife/core/subcommand_loader.rb

@@ -50,7 +50,6 @@ def site_subcommands
         # finally search ~/.chef/plugins/knife/*.rb
         user_specific_files.concat Dir.glob(File.join(env['HOME'], '.chef', 'plugins', 'knife', '*.rb'))
 
-        user_specific_files.map! { |path| path[/(.+).rb/, 1] }
         user_specific_files
       end
 

chef/spec/unit/knife/core/subcommand_loader_spec.rb

@@ -43,12 +43,12 @@
   end
 
   it "finds user-specific subcommands in the user's ~/.chef directory" do
-    expected_command = File.join(@home, '.chef', 'plugins', 'knife', 'example_home_subcommand')
+    expected_command = File.join(@home, '.chef', 'plugins', 'knife', 'example_home_subcommand.rb')
     @loader.site_subcommands.should include(expected_command)
   end
 
   it "finds repo specific subcommands by searching for a .chef directory" do
-    expected_command = File.join(CHEF_SPEC_DATA, 'knife-site-subcommands', 'plugins', 'knife', 'example_subcommand')
+    expected_command = File.join(CHEF_SPEC_DATA, 'knife-site-subcommands', 'plugins', 'knife', 'example_subcommand.rb')
     @loader.site_subcommands.should include(expected_command)
   end
 end