minikube-test-cluster needed the ensure-build-image dependency

markmandel · markmandel · commit ca8a8d22dde8 · 2018-05-02T09:32:11.000-07:00
The Make target `minikube-test-cluster` didn't have the `ensure-build-image`
dependency, so if you started a cluster, without having the image
already available, the creation of the minikube cluster would fail.
diff --git a/build/Makefile b/build/Makefile
@@ -301,7 +301,7 @@ clean-gcloud-config:
 #
 # Use MINIKUBE_DRIVER variable to change the VM driver
 # (defaults virtualbox for Linux and macOS, hyperv for windows) if you so desire.
-minikube-test-cluster: minikube-agones-profile
+minikube-test-cluster: ensure-build-image minikube-agones-profile
 	$(MINIKUBE) start --kubernetes-version v1.9.4 --vm-driver $(MINIKUBE_DRIVER) \
 		--extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
 		--extra-config=apiserver.Authorization.Mode=RBAC

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ clean-gcloud-config:`
`301`	`301`	`#`
`302`	`302`	`# Use MINIKUBE_DRIVER variable to change the VM driver`
`303`	`303`	`# (defaults virtualbox for Linux and macOS, hyperv for windows) if you so desire.`
`304`		`-minikube-test-cluster: minikube-agones-profile`
	`304`	`+minikube-test-cluster: ensure-build-image minikube-agones-profile`
`305`	`305`	`$(MINIKUBE) start --kubernetes-version v1.9.4 --vm-driver $(MINIKUBE_DRIVER) \`
`306`	`306`	`--extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \`
`307`	`307`	`--extra-config=apiserver.Authorization.Mode=RBAC`