Merge pull request agones-dev#139 from Deleplace/go-vet-20180313

enocom · web-flow · commit bc575f8bec50 · 2018-03-13T17:56:37.000-06:00
go vet: 3 warnings, 2 of them are easy.
diff --git a/examples/simple-udp/server/main.go b/examples/simple-udp/server/main.go
@@ -107,7 +107,6 @@ func doHealth(sdk *sdk.SDK, stop <-chan bool) {
 		case <-stop:
 			log.Print("Stopped health pings")
 			return
-			break
 		case <-tick:
 		}
 	}
diff --git a/pkg/gameservers/helper_test.go b/pkg/gameservers/helper_test.go
@@ -144,7 +144,7 @@ func testHTTPHealth(t *testing.T, url string, expectedResponse string, expectedS
 	err := wait.PollImmediate(time.Second, 20*time.Second, func() (done bool, err error) {
 		resp, err := http.Get(url)
 		if err != nil {
-			logrus.WithError(err).Error("Error connecting to %v", url)
+			logrus.WithError(err).Error("Error connecting to ", url)
 			return false, nil
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,6 @@ func doHealth(sdk *sdk.SDK, stop <-chan bool) {`
`107`	`107`	`case <-stop:`
`108`	`108`	`log.Print("Stopped health pings")`
`109`	`109`	`return`
`110`		`- break`
`111`	`110`	`case <-tick:`
`112`	`111`	`}`
`113`	`112`	`}`
Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func testHTTPHealth(t *testing.T, url string, expectedResponse string, expectedS`
`144`	`144`	`err := wait.PollImmediate(time.Second, 20*time.Second, func() (done bool, err error) {`
`145`	`145`	`resp, err := http.Get(url)`
`146`	`146`	`if err != nil {`
`147`		`- logrus.WithError(err).Error("Error connecting to %v", url)`
	`147`	`+ logrus.WithError(err).Error("Error connecting to ", url)`
`148`	`148`	`return false, nil`
`149`	`149`	`}`
`150`	`150`