Fix flakyness with TestSidecarHTTPHealthCheck

markmandel · markmandel · commit 84b60d5ac495 · 2018-08-01T09:25:19.000-07:00
I believe that this is starting at the same time as another
http server on the same port, and having a collision.

Removing the parrallel marker should fix this.
diff --git a/pkg/gameservers/sdkserver_test.go b/pkg/gameservers/sdkserver_test.go
@@ -295,8 +295,6 @@ func TestSidecarHealthy(t *testing.T) {
 }
 
 func TestSidecarHTTPHealthCheck(t *testing.T) {
-	t.Parallel()
-
 	m := agtesting.NewMocks()
 	sc, err := NewSDKServer("test", "default",
 		false, 1*time.Second, 1, 0, m.KubeClient, m.AgonesClient)

Original file line number	Diff line number	Diff line change
`@@ -295,8 +295,6 @@ func TestSidecarHealthy(t *testing.T) {`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`func TestSidecarHTTPHealthCheck(t *testing.T) {`
`298`		`- t.Parallel()`
`299`		`-`
`300`	`298`	`m := agtesting.NewMocks()`
`301`	`299`	`sc, err := NewSDKServer("test", "default",`
`302`	`300`	`false, 1*time.Second, 1, 0, m.KubeClient, m.AgonesClient)`