extracted parts of pkg/gameservers that deal with SDK server into pkg/sdkserver

Author: jkowalski

cmd/sdk-server/main.go

@@ -25,8 +25,8 @@ import (
 
 	"agones.dev/agones/pkg"
 	"agones.dev/agones/pkg/client/clientset/versioned"
-	"agones.dev/agones/pkg/gameservers"
 	"agones.dev/agones/pkg/sdk"
+	"agones.dev/agones/pkg/sdkserver"
 	"agones.dev/agones/pkg/util/runtime"
 	"agones.dev/agones/pkg/util/signals"
 	gwruntime "github.com/grpc-ecosystem/grpc-gateway/runtime"
@@ -108,8 +108,8 @@ func main() {
 			logger.WithError(err).Fatalf("Could not create the agones api clientset")
 		}
 
-		var s *gameservers.SDKServer
-		s, err = gameservers.NewSDKServer(viper.GetString(gameServerNameEnv),
+		var s *sdkserver.SDKServer
+		s, err = sdkserver.NewSDKServer(viper.GetString(gameServerNameEnv),
 			viper.GetString(podNamespaceEnv), kubeClient, agonesClient)
 		if err != nil {
 			logger.WithError(err).Fatalf("Could not start sidecar")
@@ -146,7 +146,7 @@ func registerLocal(grpcServer *grpc.Server, ctlConf config) error {
 		}
 	}
 
-	local, err := gameservers.NewLocalSDKServer(filePath)
+	local, err := sdkserver.NewLocalSDKServer(filePath)
 	if err != nil {
 		return err
 	}

pkg/gameservers/controller_test.go

@@ -1106,3 +1106,14 @@ func newFakeController() (*Controller, agtesting.Mocks) {
 	c.recorder = m.FakeRecorder
 	return c, m
 }
+
+func newSingleContainerSpec() v1alpha1.GameServerSpec {
+	return v1alpha1.GameServerSpec{
+		Ports: []v1alpha1.GameServerPort{{ContainerPort: 7777, HostPort: 9999, PortPolicy: v1alpha1.Static}},
+		Template: corev1.PodTemplateSpec{
+			Spec: corev1.PodSpec{
+				Containers: []corev1.Container{{Name: "container", Image: "container/image"}},
+			},
+		},
+	}
+}

pkg/gameservers/helper_test.go pkg/sdkserver/helper_test.gopkg/gameservers/helper_test.go renamed to pkg/sdkserver/helper_test.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"context"
@@ -22,27 +22,14 @@ import (
 	"testing"
 	"time"
 
-	"agones.dev/agones/pkg/apis/stable/v1alpha1"
 	"agones.dev/agones/pkg/sdk"
 	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/assert"
 	netcontext "golang.org/x/net/context"
 	"google.golang.org/grpc/metadata"
-	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/util/wait"
 )
 
-func newSingleContainerSpec() v1alpha1.GameServerSpec {
-	return v1alpha1.GameServerSpec{
-		Ports: []v1alpha1.GameServerPort{{ContainerPort: 7777, HostPort: 9999, PortPolicy: v1alpha1.Static}},
-		Template: corev1.PodTemplateSpec{
-			Spec: corev1.PodSpec{
-				Containers: []corev1.Container{{Name: "container", Image: "container/image"}},
-			},
-		},
-	}
-}
-
 func testHTTPHealth(t *testing.T, url string, expectedResponse string, expectedStatus int) {
 	// do a poll, because this code could run before the health check becomes live
 	err := wait.PollImmediate(time.Second, 20*time.Second, func() (done bool, err error) {

pkg/gameservers/localsdk.go pkg/sdkserver/localsdk.gopkg/gameservers/localsdk.go renamed to pkg/sdkserver/localsdk.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"io"

pkg/gameservers/localsdk_test.go pkg/sdkserver/localsdk_test.gopkg/gameservers/localsdk_test.go renamed to pkg/sdkserver/localsdk_test.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"encoding/json"

pkg/gameservers/sdk.go pkg/sdkserver/sdk.gopkg/gameservers/sdk.go renamed to pkg/sdkserver/sdk.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"agones.dev/agones/pkg/apis/stable/v1alpha1"

pkg/gameservers/sdk_test.go pkg/sdkserver/sdk_test.gopkg/gameservers/sdk_test.go renamed to pkg/sdkserver/sdk_test.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"testing"

pkg/gameservers/sdkserver.go pkg/sdkserver/sdkserver.gopkg/gameservers/sdkserver.go renamed to pkg/sdkserver/sdkserver.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"io"

pkg/gameservers/sdkserver_test.go pkg/sdkserver/sdkserver_test.gopkg/gameservers/sdkserver_test.go renamed to pkg/sdkserver/sdkserver_test.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package gameservers
+package sdkserver
 
 import (
 	"net/http"