add shadows to pathfinding orbs to better represent their height.

Author: Warboy1982

Makefile.am

@@ -28,6 +28,8 @@ pkgdata_DATA = bin/data/README.txt
 resourcesdir =  $(pkgdatadir)/data/Resources
 resources_DATA = \
 	bin/data/Resources/Pathfinding_Orb.png \
+	bin/data/Resources/Pathfinding_Shadow.png \
+	bin/data/Resources/Floating_Orb.png \
 	bin/data/Resources/Alternate_Pathfinding_Orb.png
 
 rulesetdir =  $(pkgdatadir)/data/Ruleset

bin/data/Resources/Floating_Orb.png

@@ -2833,6 +2833,14 @@ items:
     recover: false
     floorSprite: 73
     weight: 1000
+  - type: FLOATING_ORB
+    recover: false
+    floorSprite: 74
+    weight: 1000
+  - type: PATHFINDER_SHADOW
+    recover: false
+    floorSprite: 75
+    weight: 999
 ufos:
   - type: STR_SMALL_SCOUT
     size: STR_VERY_SMALL
@@ -9321,6 +9329,8 @@ extraSprites:
   - type: FLOOROB.PCK
     files:
       73: Resources/Pathfinding_Orb.png
+      74: Resources/Floating_Orb.png
+      75: Resources/Pathfinding_Shadow.png
 #New spritesheet Example:
 #  - type: GIANTBUNNY.PCK
 #    width: 32

bin/data/Resources/Pathfinding_Orb.png

@@ -797,18 +797,33 @@ bool Pathfinding::previewPath(bool bRemove)
 				Tile *tileBelow = _save->getTile(pos + Position(x,y,-1));
 				if (!bRemove)
 				{
-					BattleItem *item = new BattleItem(_save->getBattleState()->getGame()->getRuleset()->getItem("PATHFINDER_ORB"), _save->getCurrentItemId());
+					BattleItem *item;
+					if (tile->getPosition().z > 0 && tile->hasNoFloor(tileBelow))
+					{
+						BattleItem *itemB = new BattleItem(_save->getBattleState()->getGame()->getRuleset()->getItem("PATHFINDER_SHADOW"), _save->getCurrentItemId());
+						tile->addItem(itemB, _save->getBattleState()->getGame()->getRuleset()->getInventory("STR_GROUND"));
+						_save->getTileEngine()->applyGravity(tile);
+						item = new BattleItem(_save->getBattleState()->getGame()->getRuleset()->getItem("FLOATING_ORB"), _save->getCurrentItemId());
+					}
+					else
+					{
+						item = new BattleItem(_save->getBattleState()->getGame()->getRuleset()->getItem("PATHFINDER_ORB"), _save->getCurrentItemId());
+					}
 					tile->addItem(item, _save->getBattleState()->getGame()->getRuleset()->getInventory("STR_GROUND"));
 				}
 				else
 				{
-					for (std::vector<BattleItem*>::iterator j = tile->getInventory()->begin(); j != tile->getInventory()->end(); ++j)
+					Tile *tile2 = _save->getTileEngine()->applyGravity(tile);
+					for (std::vector<BattleItem*>::iterator j = tile2->getInventory()->begin(); j != tile2->getInventory()->end();)
 					{
-						if ((*j)->getRules()->getType() == "PATHFINDER_ORB")
+						if ((*j)->getRules()->getType() == "PATHFINDER_ORB" || (*j)->getRules()->getType() == "PATHFINDER_SHADOW" || (*j)->getRules()->getType() == "FLOATING_ORB")
 						{
 							delete *j;
-							tile->getInventory()->erase(j);
-							break;
+							j = tile2->getInventory()->erase(j);
+						}
+						else
+						{
+							++j;
 						}
 					}
 				}

bin/data/Resources/Pathfinding_Shadow.png

@@ -817,7 +817,10 @@ struct ColorReplace
 		if(src)
 		{
 			const int newShade = (src&15) + shade;
-			if (newShade > 15)
+			if (src > 248)
+				// preserve blacks.
+				dest = src;
+			else if (newShade > 15)
 				// so dark it would flip over to another color - make it black instead
 				dest = 15;
 			else