chore: clean files for PHP 8.4 (#240)

Author: rancoud

src/Configurator.php

@@ -4,9 +4,6 @@
 
 namespace Rancoud\Database;
 
-/**
- * Class Configurator.
- */
 class Configurator
 {
     /** @var string Driver */

src/Database.php

@@ -6,9 +6,6 @@
 
 namespace Rancoud\Database;
 
-/**
- * Class Database.
- */
 class Database
 {
     /** @var Configurator|null Configurator */
@@ -32,7 +29,6 @@ class Database
     /** @var int Transaction depth */
     protected int $transactionDepth = 0;
 
-    /** Database constructor. */
     public function __construct(Configurator $configurator)
     {
         $this->configurator = $configurator;
@@ -116,7 +112,7 @@ protected function prepareBind(string $sql, array $parameters = []): \PDOStateme
             if ($statement === false) {
                 throw new DatabaseException('Error Prepare Statement');
             }
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             $this->addErrorPrepare($sql, $parameters);
 
             throw new DatabaseException('Error Prepare Statement');
@@ -140,7 +136,7 @@ protected function prepareBind(string $sql, array $parameters = []): \PDOStateme
                     throw new DatabaseException('Error Bind Value');
                 }
                 // @codeCoverageIgnoreStart
-            } catch (\Exception $e) {
+            } catch (\Exception) {
                 // Could not reach this statement without mocking database
                 $this->addErrorPrepare($sql, $parameters);
 
@@ -268,7 +264,7 @@ protected function executeStatement(\PDOStatement $statement): void
             if ($success === false) {
                 throw new DatabaseException('Error Execute');
             }
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             $this->addErrorStatement($statement);
 
             throw new DatabaseException('Error Execute');
@@ -519,7 +515,7 @@ public function startTransaction(): void
 
             ++$this->transactionDepth;
             // @codeCoverageIgnoreStart
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // Could not reach this statement without mocking database
             throw new DatabaseException('Error Begin Transaction');
         }
@@ -562,7 +558,7 @@ public function commitTransaction(): void
                 $this->exec('RELEASE SAVEPOINT LEVEL' . $this->transactionDepth);
             }
             // @codeCoverageIgnoreStart
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // Could not reach this statement without mocking database
             throw new DatabaseException('Error Commit Transaction');
         }
@@ -591,7 +587,7 @@ public function rollbackTransaction(): void
                 $this->exec('ROLLBACK TO SAVEPOINT LEVEL' . $this->transactionDepth);
             }
             // @codeCoverageIgnoreStart
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // Could not reach this statement without mocking database
             throw new DatabaseException('Error Rollback Transaction');
         }

src/DatabaseException.php

@@ -4,7 +4,4 @@
 
 namespace Rancoud\Database;
 
-/**
- * Class DatabaseException.
- */
 class DatabaseException extends \Exception {}

tests/ConfiguratorTest.php

@@ -8,11 +8,7 @@
 use Rancoud\Database\Configurator;
 use Rancoud\Database\DatabaseException;
 
-/**
- * Class ConfiguratorTest.
- *
- * @internal
- */
+/** @internal */
 class ConfiguratorTest extends TestCase
 {
     /** @throws DatabaseException */

tests/DatabaseNamedInstancesTest.php

@@ -13,11 +13,7 @@
 use Rancoud\Database\Database;
 use Rancoud\Database\DatabaseException;
 
-/**
- * Class DatabaseNamedInstancesTest.
- *
- * @internal
- */
+/** @internal */
 class DatabaseNamedInstancesTest extends TestCase
 {
     protected ?Database $db;

tests/DatabaseTest.php

@@ -15,11 +15,7 @@
 use Rancoud\Database\Database;
 use Rancoud\Database\DatabaseException;
 
-/**
- * Class DatabaseTest.
- *
- * @internal
- */
+/** @internal */
 class DatabaseTest extends TestCase
 {
     protected array $dbms = [
@@ -1185,15 +1181,15 @@ public function testCommitTransactionException(string $driver): void
 
         try {
             $db->commitTransaction();
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
             --$exceptionsThrowed;
         }
 
         $db->disconnect();
 
         try {
             $db->commitTransaction();
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
             --$exceptionsThrowed;
         }
 
@@ -1251,15 +1247,15 @@ public function testRollbackTransactionException(string $driver): void
 
         try {
             $db->rollbackTransaction();
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
             --$exceptionsThrowed;
         }
 
         $db->disconnect();
 
         try {
             $db->rollbackTransaction();
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
             --$exceptionsThrowed;
         }
 
@@ -1386,7 +1382,7 @@ public function testCompleteTransactionKO(string $driver): void
             $db->update($sql, $params);
 
             $db->select('aaa');
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
         } finally {
             $db->completeTransaction();
         }
@@ -1441,7 +1437,7 @@ public function testErrorsException(string $driver): void
             $db->select('aaa');
             // if assert is done then it's not good
             static::fail();
-        } catch (DatabaseException $e) {
+        } catch (DatabaseException) {
             static::assertTrue($db->hasErrors());
             static::assertCount(4, $db->getLastError());