Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/devstack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master@{1day}
Choose a base ref
...
head repository: openstack/devstack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 29, 2026

  1. ovs: Fix OVS path mismatch when building from source with OVN

    ``compile_ovs`` was called with ``--localstatedir=/var``, causing
    all compiled OVS binaries to hardcode ``/var/run/openvswitch`` as
    the default runtime directory. However, the ``ovn_agent`` plugin
    derives ``OVS_RUNDIR`` from ``OVS_PREFIX`` as
    ``/usr/local/var/run/openvswitch``, creating a path mismatch that
    makes ``ovs-vsctl`` unable to reach the running ``ovsdb-server``.
    
    Additionally, ``start_new_ovs`` was unconditionally starting OVS
    during the install phase. When OVN is the backend,
    ``ovn_agent:_start_ovs`` later starts its own OVS instance with a
    separate database, but the orphaned ``ovs-vswitchd`` from
    ``start_new_ovs`` still holds the kernel datapath, preventing
    bridge creation.
    
    Fix both issues:
    - Remove the ``--localstatedir=/var`` override so the compiled
      default matches ``OVS_RUNDIR`` (autotools defaults localstatedir
      to ``${prefix}/var``).
    - Skip ``start_new_ovs`` when OVN services are enabled, since
      ``_start_ovs`` handles the full OVS lifecycle.
    - Fix the hardcoded DB path in ``start_new_ovs`` to match the
      compiled ``--prefix=/usr/local`` sysconfdir.
    
    Closes-Bug: #2158954
    Assisted-By: Claude Opus 4.6
    Signed-off-by: Rodolfo Alonso Hernandez <ralonsoh@redhat.com>
    Change-Id: I8f3a2c5e7d1b4a9f6e0c3d8b2a5f7e1d4c6b9a0e
    ralonsoh committed Jul 29, 2026
    Configuration menu
    Copy the full SHA
    9b0a008 View commit details
    Browse the repository at this point in the history
Loading