Refactor experimental debugger (#910)

Fixes DonJayamanne#822
Removes some of the unwanted setTimeouts (work arounds) with changes to upstream PTVSD

Author: DonJayamanne

package.json

@@ -1790,7 +1790,6 @@
         "md5": "^2.2.1",
         "minimatch": "^3.0.3",
         "named-js-regexp": "^1.3.1",
-        "once": "^1.4.0",
         "opn": "^5.1.0",
         "pidusage": "^1.2.0",
         "reflect-metadata": "^0.1.12",
@@ -1825,7 +1824,6 @@
         "@types/md5": "^2.1.32",
         "@types/mocha": "^2.2.43",
         "@types/node": "^6.0.40",
-        "@types/once": "^1.4.0",
         "@types/semver": "^5.4.0",
         "@types/shortid": "0.0.29",
         "@types/sinon": "^2.3.2",

src/client/common/core.utils.ts

@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+'use strict';
+
+export async function sleep(timeout: number) {
+    return new Promise(resolve => setTimeout(resolve, timeout));
+}
+
+// tslint:disable-next-line:no-empty
+export function noop() { }

src/client/common/net/socket/socketServer.ts

@@ -1,6 +1,7 @@
 import { EventEmitter } from 'events';
 import { injectable } from 'inversify';
 import * as net from 'net';
+import { noop } from '../../core.utils';
 import { createDeferred, Deferred } from '../../helpers';
 import { ISocketServer } from '../../types';
 
@@ -56,8 +57,7 @@ export class SocketServer extends EventEmitter implements ISocketServer {
         client.on('data', (data: Buffer) => {
             this.emit('data', client, data);
         });
-        // tslint:disable-next-line:no-empty
-        client.on('error', (err: Error) => { });
+        client.on('error', (err: Error) => noop);
 
         client.on('timeout', d => {
             // let msg = "Debugger client timedout, " + d;

src/client/common/process/currentProcess.ts

@@ -4,6 +4,11 @@ import { EnvironmentVariables } from '../variables/types';
 
 @injectable()
 export class CurrentProcess implements ICurrentProcess {
+    public on = (event: string | symbol, listener: Function): this => {
+        process.on(event, listener);
+        // tslint:disable-next-line:no-any
+        return process as any;
+    }
     public get env(): EnvironmentVariables {
         return process.env;
     }

src/client/common/types.ts

@@ -91,6 +91,7 @@ export interface ICurrentProcess {
     readonly argv: string[];
     readonly stdout: NodeJS.WriteStream;
     readonly stdin: NodeJS.ReadStream;
+    on(event: string | symbol, listener: Function): this;
 }
 
 export interface IPythonSettings {

src/client/debugger/mainV2.ts

@@ -9,6 +9,9 @@ import { EnvironmentVariables } from '../../client/common/variables/types';
 @injectable()
 export class MockProcess implements ICurrentProcess {
     constructor(public env: EnvironmentVariables = { ...process.env }) { }
+    public on(event: string | symbol, listener: Function): this {
+        return this;
+    }
     public get argv(): string[] {
         return [];
     }

src/test/mocks/process.ts

@@ -94,10 +94,6 @@
   version "6.0.95"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-6.0.95.tgz#0d027612a77c55b84497ff90a4a7d597e5ac0fab"
 
-"@types/once@^1.4.0":
-  version "1.4.0"
-  resolved "https://registry.yarnpkg.com/@types/once/-/once-1.4.0.tgz#7bfe3d99a0951f3141bac2617c9827525788b8f5"
-
 "@types/semver@^5.4.0":
   version "5.4.0"
   resolved "https://registry.yarnpkg.com/@types/semver/-/semver-5.4.0.tgz#f3658535af7f1f502acd6da7daf405ffeb1f7ee4"