Added telemetry for code refactoring

Author: DonJayamanne

src/client/common/telemetryContracts.ts

@@ -1,19 +1,23 @@
 export namespace Debugger {
-    export const Load = "DEBUGGER_LOAD";
-    export const Attach = "DEBUGGER_ATTACH";
+    export const Load = 'DEBUGGER_LOAD';
+    export const Attach = 'DEBUGGER_ATTACH';
 }
 export namespace Commands {
-    export const SortImports = "COMMAND_SORT_IMPORTS";
-    export const UnitTests = "COMMAND_UNIT_TEST";
+    export const SortImports = 'COMMAND_SORT_IMPORTS';
+    export const UnitTests = 'COMMAND_UNIT_TEST';
 }
 export namespace IDE {
-    export const Completion = "CODE_COMPLETION";
-    export const Definition = "CODE_DEFINITION";
-    export const Format = "CODE_FORMAT";
-    export const HoverDefinition = "CODE_HOVER_DEFINITION";
-    export const Reference = "CODE_REFERENCE";
-    export const Rename = "CODE_RENAME";
-    export const Symbol = "CODE_SYMBOL";
-    export const Lint = "LINTING";
+    export const Completion = 'CODE_COMPLETION';
+    export const Definition = 'CODE_DEFINITION';
+    export const Format = 'CODE_FORMAT';
+    export const HoverDefinition = 'CODE_HOVER_DEFINITION';
+    export const Reference = 'CODE_REFERENCE';
+    export const Rename = 'CODE_RENAME';
+    export const Symbol = 'CODE_SYMBOL';
+    export const Lint = 'LINTING';
 }
-export const EVENT_LOAD = "IDE_LOAD";
+export namespace REFACTOR {
+    export const ExtractVariable = 'REFACTOR_EXTRACT_VAR';
+    export const ExtractMethod = 'REFACTOR_EXTRACT_METHOD';
+}
+export const EVENT_LOAD = 'IDE_LOAD';

src/client/refactor/proxy.ts

@@ -7,6 +7,8 @@ import * as child_process from 'child_process';
 import {ExtractResult} from './contracts';
 import {execPythonFile} from '../common/utils';
 import {IPythonSettings} from '../common/configSettings';
+import {REFACTOR} from '../common/telemetryContracts';
+import {sendTelemetryEvent, Delays} from '../common/telemetry';
 
 const ROPE_PYTHON_VERSION = 'Currently code refactoring is only supported in Python 2.x';
 const ERROR_PREFIX = '$ERROR';
@@ -39,13 +41,14 @@ export class RefactorProxy extends vscode.Disposable {
     }
     extractVariable<T>(document: vscode.TextDocument, name: string, filePath: string, range: vscode.Range): Promise<T> {
         let command = `{"lookup":"extract_variable", "file":"${filePath}", "start":"${document.offsetAt(range.start)}", "end":"${document.offsetAt(range.end)}", "id":"1", "name":"${name}"}`;
-        return this.sendCommand<T>(command);
+        return this.sendCommand<T>(command, REFACTOR.ExtractVariable);
     }
     extractMethod<T>(document: vscode.TextDocument, name: string, filePath: string, range: vscode.Range): Promise<T> {
         let command = `{"lookup":"extract_method", "file":"${filePath}", "start":"${document.offsetAt(range.start)}", "end":"${document.offsetAt(range.end)}", "id":"1","name":"${name}"}`;
-        return this.sendCommand<T>(command);
+        return this.sendCommand<T>(command, REFACTOR.ExtractVariable);
     }
-    private sendCommand<T>(command: string): Promise<T> {
+    private sendCommand<T>(command: string, telemetryEvent: string): Promise<T> {
+        let timer = new Delays();
         return this.pickValidPythonPath().then(pythonPath => {
             return this.initialize(pythonPath);
         }).then(() => {
@@ -54,6 +57,10 @@ export class RefactorProxy extends vscode.Disposable {
                 this._commandReject = reject;
                 this._process.stdin.write(command + '\n');
             });
+        }).then(value => {
+            timer.stop();
+            sendTelemetryEvent(telemetryEvent, null, timer.toMeasures());
+            return value;
         });
     }