CLOUDSTACK-6047: Introduce VR resource unit test

Author: Sheng Yang

core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java

@@ -133,6 +133,8 @@ public Answer executeRequest(final NetworkElementCommand cmd) {
                 return new Answer(cmd, false, rc.getDetails());
             }
 
+            assert cmd.getRouterAccessIp() != null : "Why there is no access IP for VR?";
+
             if (cmd.isQuery()) {
                 return executeQueryCommand(cmd);
             }
@@ -421,7 +423,7 @@ private List<ConfigItem> generateConfig(SetPortForwardingRulesCommand cmd) {
 
         for (PortForwardingRuleTO rule : cmd.getRules()) {
             StringBuilder args = new StringBuilder();
-            args.append(rule.revoked() ? " -D " : " -A ");
+            args.append(rule.revoked() ? "-D" : "-A");
             args.append(" -P ").append(rule.getProtocol().toLowerCase());
             args.append(" -l ").append(rule.getSrcIp());
             args.append(" -p ").append(rule.getStringSrcPortRange());
@@ -812,7 +814,7 @@ protected List<ConfigItem> generateConfig(SetSourceNatCommand cmd) {
 
         IpAddressTO pubIP = cmd.getIpAddress();
         String dev = "eth" + pubIP.getNicDevId();
-        String args = " -A ";
+        String args = "-A";
         args += " -l ";
         args += pubIP.getPublicIp();
         args += " -c ";
@@ -826,7 +828,7 @@ protected List<ConfigItem> generateConfig(SetPortForwardingRulesVpcCommand cmd)
         LinkedList<ConfigItem> cfg = new LinkedList<>();
 
         for (PortForwardingRuleTO rule : cmd.getRules()) {
-            String args = rule.revoked() ? " -D" : " -A";
+            String args = rule.revoked() ? "-D" : "-A";
             args += " -P " + rule.getProtocol().toLowerCase();
             args += " -l " + rule.getSrcIp();
             args += " -p " + rule.getStringSrcPortRange();