CLOUDSTACK-305. Everytime a SOAP call is made some transactions are rolled back because the transactions are not committed.

Author: Likitha Shetty

awsapi/src/com/cloud/bridge/persist/dao/CloudStackConfigurationDaoImpl.java

@@ -54,7 +54,8 @@ public String getConfigValue(String name) {
             }
             return configItem.getValue();
         }finally {
-
+            txn.commit();
+            txn.close();
         }
     }
 

awsapi/src/com/cloud/bridge/persist/dao/CloudStackSvcOfferingDaoImpl.java

@@ -50,6 +50,7 @@ public CloudStackServiceOfferingVO getSvcOfferingByName( String name ){
             return findOneBy(sc);
 
         }finally {
+            txn.commit();
             txn.close();
         }
 
@@ -68,6 +69,7 @@ public CloudStackServiceOfferingVO getSvcOfferingById( String id ){
             return findOneBy(sc);
 
         }finally {
+            txn.commit();
             txn.close();
         }
 

awsapi/src/com/cloud/bridge/persist/dao/CloudStackUserDaoImpl.java

@@ -55,6 +55,7 @@ public String getSecretKeyByAccessKey( String accessKey ) {
             }
             return cloudSecretKey;
         } finally {
+            txn.commit();
             txn.close();
         }
     }

awsapi/src/com/cloud/bridge/persist/dao/MHostDaoImpl.java

@@ -44,10 +44,10 @@ public MHostVO getByHostKey(String hostKey) {
 		SearchCriteria<MHostVO> sc = NameSearch.create();
 		sc.setParameters("MHostKey", hostKey);
 		return findOneBy(sc);
-		
-	    }finally {
-		txn.close();
-	    }
+        } finally {
+            txn.commit();
+            txn.close();
+        }
 	}
 
     @Override

awsapi/src/com/cloud/bridge/persist/dao/OfferingDaoImpl.java

@@ -43,7 +43,8 @@ public int getOfferingCount() {
         try {
             txn.start();
             return listAll().size();
-        }finally {
+        } finally {
+            txn.commit();
             txn.close();
         }
 
@@ -61,8 +62,8 @@ public String getCloudOffering( String amazonEC2Offering ) {
            SearchCriteria<OfferingBundleVO> sc = searchByAmazon.create();
            sc.setParameters("AmazonEC2Offering", amazonEC2Offering);
            return findOneBy(sc).getCloudstackOffering();
-           
         } finally {
+            txn.commit();
             txn.close();
         }
 	}
@@ -79,8 +80,8 @@ public String getAmazonOffering( String cloudStackOffering ) {
 	           SearchCriteria<OfferingBundleVO> sc = searchByAmazon.create();
 	           sc.setParameters("CloudStackOffering", cloudStackOffering);
 	           return findOneBy(sc).getAmazonOffering();
-	           
 	        } finally {
+                txn.commit();
 	            txn.close();
 	        }
 	    }
@@ -109,7 +110,6 @@ public void setOfferMapping( String amazonEC2Offering, String cloudStackOffering
                 offering = persist(offering);
             else
                 update(offering.getID(), offering);
-
             txn.commit();
          } finally {
              txn.close();

awsapi/src/com/cloud/bridge/persist/dao/SHostDaoImpl.java

@@ -42,8 +42,8 @@ public SHostVO getByHost(String host) {
     		SearchCriteria<SHostVO> sc = HostSearch.create();
     		sc.setParameters("Host", host);
     		return findOneBy(sc);
-		
-	    }finally {
+        } finally {
+            txn.commit();
 	        txn.close();
 	    }
 
@@ -62,8 +62,8 @@ public SHostVO getLocalStorageHost(long mhostId, String storageRoot) {
             sc.setParameters("MHostID", mhostId);
             sc.setParameters("ExportRoot", storageRoot);
             return findOneBy(sc);
-		
-	    }finally {
+        } finally {
+            txn.commit();
             txn.close();
 	    }	
 	}

awsapi/src/com/cloud/bridge/persist/dao/UserCredentialsDaoImpl.java

@@ -67,6 +67,7 @@ public UserCredentialsVO getByCertUniqueId( String certId ) {
             sc.setParameters("CertUniqueId", certId);
             return findOneBy(sc);
 	    }finally {
+            txn.commit();
 	        txn.close();
 	    }