Skip to content

Commit ff1db77

Browse files
vespertilianijjk
andauthored
change aria-disabled on form buttons to disabled (vercel#63852)
- aria-disabled does not disable the button <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: JJ Kasper <jj@jjsweb.site>
1 parent 29d53c8 commit ff1db77

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/02-app/01-building-your-application/02-data-fetching/02-server-actions-and-mutations.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ export function SubmitButton() {
243243
const { pending } = useFormStatus()
244244

245245
return (
246-
<button type="submit" aria-disabled={pending}>
246+
<button type="submit" disabled={pending}>
247247
Add
248248
</button>
249249
)
@@ -259,7 +259,7 @@ export function SubmitButton() {
259259
const { pending } = useFormStatus()
260260

261261
return (
262-
<button type="submit" aria-disabled={pending}>
262+
<button type="submit" disabled={pending}>
263263
Add
264264
</button>
265265
)

0 commit comments

Comments
 (0)