Skip to content

Commit 2d48856

Browse files
Sandeep-Manileerobsamcx
authored
Fixed vercel#61434 : Docs: Duplicated code snippets (vercel#61446)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? Issue - Docs: Duplicated code snippets The code snippet is repeated, second snippet had to be with Link component. ### How? Replaced button with Link component. Fixes vercel#61434 - Docs: Duplicated code snippets --------- Co-authored-by: Lee Robinson <me@leerob.io> Co-authored-by: Sam Ko <sam@vercel.com>
1 parent b1f6b82 commit 2d48856

1 file changed

Lines changed: 28 additions & 3 deletions

File tree

docs/02-app/01-building-your-application/01-routing/10-parallel-routes.mdx

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ When the user clicks the `<Link>`, the modal will open instead of navigating to
357357

358358
You can close the modal by calling `router.back()` or by using the `Link` component.
359359

360-
```tsx filename="app/ui/modal.tsx switcher
360+
```tsx filename="app/ui/modal.tsx" switcher
361361
'use client'
362362

363363
import { useRouter } from 'next/navigation'
@@ -380,7 +380,7 @@ export function Modal({ children }: { children: React.ReactNode }) {
380380
}
381381
```
382382

383-
```tsx filename="app/ui/modal.tsx switcher
383+
```jsx filename="app/ui/modal.js" switcher
384384
'use client'
385385

386386
import { useRouter } from 'next/navigation'
@@ -391,7 +391,6 @@ export function Modal({ children }) {
391391
return (
392392
<>
393393
<button
394-
type="button"
395394
onClick={() => {
396395
router.back()
397396
}}
@@ -404,6 +403,32 @@ export function Modal({ children }) {
404403
}
405404
```
406405

406+
```tsx filename="app/ui/modal.tsx" switcher
407+
import Link from 'next/link'
408+
409+
export function Modal({ children }: { children: React.ReactNode }) {
410+
return (
411+
<>
412+
<Link href="/">Close modal</Link>
413+
<div>{children}</div>
414+
</>
415+
)
416+
}
417+
```
418+
419+
```jsx filename="app/ui/modal.js" switcher
420+
import Link from 'next/link'
421+
422+
export function Modal({ children }) {
423+
return (
424+
<>
425+
<Link href="/">Close modal</Link>
426+
<div>{children}</div>
427+
</>
428+
)
429+
}
430+
```
431+
407432
> **Good to know:**
408433
>
409434
> - Other examples could include opening a photo modal in a gallery while also having a dedicated `/photo/[id]` page, or opening a shopping cart in a side modal.

0 commit comments

Comments
 (0)