Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 83f7ced

Browse files
committed
Add some screenshots
1 parent 52e9782 commit 83f7ced

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

docs/feature-requests/006-pull-request-reviewer-flow.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,21 @@ This tab shows all review summaries and review comments, including the ones that
2929
An alternative would be to add a footer bar at the bottom and place the add review button there. The caveat is that it might not be as noticeable as the header, and "start a new review" is an arguably more important action than "checkout".
3030

3131
#### Responding to a comment thread
32-
start a new review button
32+
![responding to a comment thread](https://user-images.githubusercontent.com/6842965/56689748-cdd05700-66a9-11e9-90e8-266c69cbc589.png)
3333

34-
#### Pending comments
34+
User can respond to a comment thread by adding a single line comment (current implementation) or starting a new review. The two buttons should only show up when the comment textbox is in focus, or is _not_ empty.
35+
36+
When there is already an existing pending review, there should only be **one** `btn-primary` button that reads "Comment".
3537

36-
Pending comments within the All Reviews tab are styled differently from the already published comments. Pending comments contain a way to direct user to the Pending Review tab.
38+
#### Pending comments
3739

40+
![image](https://user-images.githubusercontent.com/6842965/56692893-2ce59a00-66b1-11e9-81cc-bc7956bc8bec.png)
3841

42+
Pending comments within the All Reviews tab are styled differently from the already published comments. Pending comments contain a badge, and when clicked, it will take user to the Pending Review tab.
3943

4044

4145
### "Pending Review" tab
42-
This tab shows a *subset* of all reviews -- only the summary and comments of a pending review. Since a user is only allowed to have one pending review at a time, there should also only be one active Pending Review tab.
46+
This tab shows *a subset* of all reviews -- only the summary and comments of a pending review. Since a user is only allowed to have one pending review at a time, there should also only be maximum one Pending Review tab.
4347

4448
#### Header
4549
The header looks very similar to the one of All Reviews tab, with the exception that the primary button now reads "See all reviews", and will send users back to the All Reviews tab.

0 commit comments

Comments
 (0)