From 97ea6f2fa10dc89206b124e33db255dfc9dc080d Mon Sep 17 00:00:00 2001 From: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu, 3 Jun 2021 19:04:26 -0500 Subject: [PATCH 1/2] style Comments for OnDestroy method --- testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs b/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs index bda4d770a9..fb445fa012 100644 --- a/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs +++ b/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs @@ -72,6 +72,14 @@ private void OnClientConnectedCallback(ulong clientId) } } + /// + /// Remove our OnClientConnectedCallback registration when we are destroyed + /// + private void OnDestroy() + { + NetworkManager.OnClientConnectedCallback -= OnClientConnectedCallback; + } + /// /// Used by UI Button click event /// From 82acc6f66b72fa20c14d8a6f198ae05de11c9809 Mon Sep 17 00:00:00 2001 From: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu, 3 Jun 2021 19:18:47 -0500 Subject: [PATCH 2/2] fix Yamato 1 commit problems. --- testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs b/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs index fb445fa012..86b657cb67 100644 --- a/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs +++ b/testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs @@ -18,7 +18,6 @@ public class StatsDisplay : NetworkBehaviour private Text m_ClientServerToggleText; private List m_ClientsToUpdate = new List(); - private bool m_IsServer; private void Start()