Uninitialized variables; Fix false positive in switch inside loop

Author: danmar

lib/checkuninitvar.cpp

@@ -859,6 +859,12 @@ const Token* CheckUninitVar::checkLoopBodyRecursive(const Token *start, const Va
         }
 
         if (tok->str() == "{") {
+            // switch => bailout
+            if (tok->scope() && tok->scope()->type == Scope::ScopeType::eSwitch) {
+                bailout = true;
+                return nullptr;
+            }
+
             const Token *errorToken1 = checkLoopBodyRecursive(tok, var, alloc, membervar, bailout);
             tok = tok->link();
             if (Token::simpleMatch(tok, "} else {")) {

test/testuninitvar.cpp

@@ -1330,6 +1330,22 @@ class TestUninitVar : public TestFixture {
                        "    }\n"
                        "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // switch in loop
+        checkUninitVar("int foo(int *p) {\n"
+                       "  int x;\n"
+                       "  while (true) {\n"
+                       "    switch (*p) {\n"
+                       "    case 1:\n"
+                       "        return x;\n"
+                       "    case 2:\n"
+                       "        x = 123;\n"
+                       "        break;\n"
+                       "    };\n"
+                       "    ++p\n"
+                       "  }\n"
+                       "}");
+        ASSERT_EQUALS("", errout.str());
     }
 
     // switch..