[js] Fix a handful of errors encountered with the edge driver

1. findElements will return a NoSuchElementError if nothing is found. Catch
   this and return an empty list
2. remote.DriverService tries to connect to the loopback address by default,
   but EdgeDriver binds host to "localhost" by default. We cannot make the
   driver bind to the loopback address without admin privileges, so change
   the client to just connect to localhost

Author: jleyba

javascript/node/selenium-webdriver/edge.js

@@ -280,7 +280,10 @@ class ServiceBuilder {
     var args = this.args_.concat();  // Defensive copy.
 
     return new remote.DriverService(this.exe_, {
-      loopback: true,
+      // Binding to the loopback address will fail if not running with
+      // administrator privileges. Since we cannot test for that in script
+      // (or can we?), force the DriverService to use "localhost".
+      hostname: 'localhost',
       port: port,
       args: promise.fulfilled(port).then(function(port) {
         return args.concat('--port=' + port);

javascript/node/selenium-webdriver/example/logging.js

@@ -34,7 +34,10 @@ var driver = new webdriver.Builder()
     .build();
 
 driver.get('http://www.google.com/ncr');
-driver.findElement(By.name('q')).sendKeys('webdriver');
+
+var searchBox = driver.wait(until.elementLocated(By.name('q')), 3000);
+searchBox.sendKeys('webdriver');
+
 driver.findElement(By.name('btnG')).click();
 driver.wait(until.titleIs('webdriver - Google Search'), 1000);
 driver.quit();

javascript/node/selenium-webdriver/http/util.js

@@ -42,8 +42,6 @@ function getStatus(url) {
   var executor = new Executor(client);
   var command = new Command(CommandName.GET_SERVER_STATUS);
   return executor.execute(command).then(function(responseObj) {
-    console.log('GOT HERE GOT HERE GOT HERE');
-    console.dir(responseObj);
     error.checkLegacyResponse(responseObj);
     return responseObj['value'];
   });

javascript/node/selenium-webdriver/lib/test/index.js

@@ -34,6 +34,7 @@ var build = require('./build'),
  */
 var NATIVE_BROWSERS = [
   webdriver.Browser.CHROME,
+  webdriver.Browser.EDGE,
   webdriver.Browser.FIREFOX,
   webdriver.Browser.IE,
   webdriver.Browser.OPERA,
@@ -59,6 +60,9 @@ var browsersToTest = (function() {
     if (parts[0] === 'ie') {
       parts[0] = webdriver.Browser.IE;
     }
+    if (parts[0] === 'edge') {
+      parts[0] = webdriver.Browser.EDGE;
+    }
     return parts.join(':');
   });
   browsers.forEach(function(browser) {

javascript/node/selenium-webdriver/lib/webdriver.js

@@ -894,7 +894,13 @@ class WebDriver {
       let cmd = new command.Command(command.Name.FIND_ELEMENTS).
           setParameter('using', locator.using).
           setParameter('value', locator.value);
-      return this.schedule(cmd, 'WebDriver.findElements(' + locator + ')');
+      let res = this.schedule(cmd, 'WebDriver.findElements(' + locator + ')');
+      return res.thenCatch(function(e) {
+        if (e instanceof error.NoSuchElementError) {
+          return [];
+        }
+        throw e;
+      });
     }
   }
 

javascript/node/selenium-webdriver/remote/index.js

@@ -40,6 +40,8 @@ const httpUtil = require('../http/util'),
  *
  * - `loopback` - Whether the service should only be accessed on this host's
  *     loopback address.
+ * - `hostname` - The host name to access the server on. If this option is
+ *     specified, the `loopback` option will be ignored.
  * - `port` - The port to start the server on (must be > 0). If the port is
  *     provided as a promise, the service will wait for the promise to resolve
  *     before starting.
@@ -54,6 +56,7 @@ const httpUtil = require('../http/util'),
  *
  * @typedef {{
  *   loopback: (boolean|undefined),
+ *   hostname: (string|undefined),
  *   port: (number|!promise.Promise<number>),
  *   args: !(Array<string>|promise.Promise<!Array<string>>),
  *   path: (string|undefined|null),
@@ -85,6 +88,9 @@ class DriverService {
     /** @private {boolean} */
     this.loopbackOnly_ = !!options.loopback;
 
+    /** @private {(string|undefined)} */
+    this.hostname_ = options.hostname;
+
     /** @private {(number|!promise.Promise<number>)} */
     this.port_ = options.port;
 
@@ -183,10 +189,15 @@ class DriverService {
           throw error;
         });
 
+        var hostname = self.hostname_;
+        if (!hostname) {
+          hostname = !self.loopbackOnly_ && net.getAddress()
+              || net.getLoopbackAddress();
+        }
+
         var serverUrl = url.format({
           protocol: 'http',
-          hostname: !self.loopbackOnly_ && net.getAddress() ||
-              net.getLoopbackAddress(),
+          hostname: hostname,
           port: port,
           pathname: self.path_
         });