Improved MarkerView, fix issues.

Author: PhilJay

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivityMultiDataset.java

@@ -71,7 +71,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
         // define an offset to change the original position of the marker
         // (optional)
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
+//        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
 
         // set the marker to the chart
         mChart.setMarkerView(mv);

MPChartExample/src/com/xxmassdeveloper/mpchartexample/InvertedLineChartActivity.java

@@ -92,10 +92,6 @@ protected void onCreate(Bundle savedInstanceState) {
         // to use for it
         MyMarkerView mv = new MyMarkerView(this, R.layout.custom_marker_view);
 
-        // define an offset to change the original position of the marker
-        // (optional)
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
-
         // set the marker to the chart
         mChart.setMarkerView(mv);
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/LineChartActivity1.java

@@ -109,10 +109,6 @@ protected void onCreate(Bundle savedInstanceState) {
         // to use for it
         MyMarkerView mv = new MyMarkerView(this, R.layout.custom_marker_view);
 
-        // define an offset to change the original position of the marker
-        // (optional)
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
-
         // set the marker to the chart
         mChart.setMarkerView(mv);
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/LineChartActivity2.java

@@ -57,6 +57,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
         mChart = (LineChart) findViewById(R.id.chart1);
         mChart.setOnChartValueSelectedListener(this);
+        mChart.setValueTextColor(Color.WHITE);
 
         mChart.setUnit(" $");
         mChart.setDrawUnitsInChart(true);

MPChartExample/src/com/xxmassdeveloper/mpchartexample/MyMarkerView.java

@@ -9,6 +9,11 @@
 import com.github.mikephil.charting.utils.MarkerView;
 import com.github.mikephil.charting.utils.Utils;
 
+/**
+ * Custom implementation of the MarkerView.
+ * 
+ * @author Philipp Jahoda
+ */
 public class MyMarkerView extends MarkerView {
 
     private TextView tvContent;
@@ -34,4 +39,16 @@ public void refreshContent(Entry e, int dataSetIndex) {
             tvContent.setText("" + Utils.formatNumber(e.getVal(), 0, true));
         }
     }
+
+    @Override
+    public int getXOffset() {
+        // this will center the marker-view horizontally
+        return -(getWidth() / 2);
+    }
+
+    @Override
+    public int getYOffset() {
+        // this will cause the marker-view to be above the selected value
+        return -getHeight();
+    }
 }

MPChartExample/src/com/xxmassdeveloper/mpchartexample/RadarChartActivitry.java

@@ -53,10 +53,6 @@ protected void onCreate(Bundle savedInstanceState) {
         // to use for it
         MyMarkerView mv = new MyMarkerView(this, R.layout.custom_marker_view);
 
-        // define an offset to change the original position of the marker
-        // (optional)
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
-
         // set the marker to the chart
         mChart.setMarkerView(mv);
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/fragments/BarChartFrag.java

@@ -31,7 +31,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         mChart.setDescription("");
 
         MyMarkerView mv = new MyMarkerView(getActivity(), R.layout.custom_marker_view);
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
 
         mChart.setMarkerView(mv);
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/fragments/ScatterChartFrag.java

@@ -35,7 +35,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         labels.setTypeface(tf);
 
         MyMarkerView mv = new MyMarkerView(getActivity(), R.layout.custom_marker_view);
-        mv.setOffsets(-mv.getMeasuredWidth() / 2, -mv.getMeasuredHeight());
 
         mChart.setMarkerView(mv);
 

MPChartLib/src/com/github/mikephil/charting/charts/Chart.java

@@ -145,7 +145,7 @@ public abstract class Chart<T extends ChartData<? extends DataSet<? extends Entr
     protected Paint mLimitLinePaint;
 
     /** description text that appears in the bottom right corner of the chart */
-    protected String mDescription = "Description.";
+    protected String mDescription = "Description";
 
     /** flag that indicates if the chart has been fed with data yet */
     protected boolean mDataNotSet = true;
@@ -1048,11 +1048,24 @@ protected void drawMarkers() {
                 // callbacks to update the content
                 mMarkerView.refreshContent(e, dataSetIndex);
 
+                // mMarkerView.measure(MeasureSpec.makeMeasureSpec(0,
+                // MeasureSpec.UNSPECIFIED),
+                // MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED));
+                // mMarkerView.layout(0, 0, mMarkerView.getMeasuredWidth(),
+                // mMarkerView.getMeasuredHeight());
+                // mMarkerView.draw(mDrawCanvas, pos[0], pos[1]);
+
                 mMarkerView.measure(MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED),
                         MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED));
                 mMarkerView.layout(0, 0, mMarkerView.getMeasuredWidth(),
                         mMarkerView.getMeasuredHeight());
-                mMarkerView.draw(mDrawCanvas, pos[0], pos[1]);
+
+                if (pos[1] - mMarkerView.getHeight() <= 0) {
+                    float y = mMarkerView.getHeight() - pos[1];
+                    mMarkerView.draw(mDrawCanvas, pos[0], pos[1] + y);
+                } else {
+                    mMarkerView.draw(mDrawCanvas, pos[0], pos[1]);
+                }
             }
         }
     }
@@ -1477,6 +1490,8 @@ public void setLogEnabled(boolean enabled) {
      * @param desc
      */
     public void setDescription(String desc) {
+        if (desc == null)
+            desc = "";
         this.mDescription = desc;
     }
 

MPChartLib/src/com/github/mikephil/charting/charts/PieChart.java

@@ -563,7 +563,7 @@ public void setHoleColor(int color) {
      * Set the hole in the center of the PieChart transparent. Thank you, code
      * provided by:
      * 
-     * @link https://github.com/wogg
+     * @link https://github.com/tbarthel-fr
      * @param enable
      */
     public void setHoleColorTransparent(boolean enable) {