Skip to content

Commit d5c9f6d

Browse files
AndresAcunasjwarner-bp
authored andcommitted
Changes assertThat to assertEquals (exercism#1591)
* Changes assertThat to assertEquals * Removed unnecessary imports, fixed whitespace, and removed redundant initializations from tests
1 parent 1440171 commit d5c9f6d

1 file changed

Lines changed: 12 additions & 28 deletions

File tree

Lines changed: 12 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,11 @@
1-
import org.junit.Before;
2-
import org.junit.Ignore;
3-
import org.junit.Test;
1+
import static org.junit.Assert.assertEquals;
42

5-
import java.util.ArrayList;
6-
import java.util.HashMap;
7-
import java.util.Map;
8-
import java.util.List;
9-
import java.util.Collection;
103
import java.util.Arrays;
4+
import java.util.List;
115

12-
import org.hamcrest.Matcher;
13-
import org.hamcrest.collection.IsIterableContainingInOrder;
14-
import static org.hamcrest.CoreMatchers.*;
15-
import static org.junit.Assert.assertThat;
16-
import static org.junit.Assert.assertTrue;
17-
import static org.junit.Assert.assertEquals;
6+
import org.junit.Before;
7+
import org.junit.Ignore;
8+
import org.junit.Test;
189

1910
public class SchoolTest {
2011
private School school;
@@ -26,46 +17,41 @@ public void setUp() {
2617

2718
@Test
2819
public void addingAStudentAddsThemToTheSortedRoster() {
29-
school = new School();
3020
school.add("Aimee", 2);
3121
List<String> expected = Arrays.asList("Aimee");
32-
assertThat(school.roster(), is(expected));
22+
assertEquals(expected, school.roster());
3323
}
3424

3525
@Ignore("Remove to run test")
3626
@Test
3727
public void addingMoreStudentsAddsThemToTheSameSortedRoster() {
38-
school = new School();
3928
int grade = 2;
4029
school.add("Blair", grade);
4130
school.add("James", grade);
4231
school.add("Paul", grade);
4332
List<String> expected = Arrays.asList("Blair", "James", "Paul");
44-
assertThat(school.roster(), is(expected));
33+
assertEquals(expected, school.roster());
4534
}
4635

4736
@Ignore("Remove to run test")
4837
@Test
4938
public void addingStudentsToDifferentGradesAddsThemToTheSameSortedRoster() {
50-
school = new School();
5139
school.add("Chelsea", 3);
5240
school.add("Logan", 7);
5341
List<String> expected = Arrays.asList("Chelsea", "Logan");
54-
assertThat(school.roster(), is(expected));
42+
assertEquals(expected, school.roster());
5543
}
5644

5745
@Ignore("Remove to run test")
5846
@Test
5947
public void rosterReturnsAnEmptyListIfThereAreNoStudentsEnrolled() {
60-
school = new School();
6148
List<String> expected = Arrays.asList();
62-
assertThat(school.roster(), is(expected));
49+
assertEquals(expected, school.roster());
6350
}
6451

6552
@Ignore("Remove to run test")
6653
@Test
6754
public void studentNamesWithGradesAreDisplayedInTheSameSortedRoster() {
68-
school = new School();
6955
school.add("Peter", 2);
7056
school.add("Anna", 1);
7157
school.add("Barb", 1);
@@ -74,25 +60,23 @@ public void studentNamesWithGradesAreDisplayedInTheSameSortedRoster() {
7460
school.add("Jim", 3);
7561
school.add("Charlie", 1);
7662
List<String> expected = Arrays.asList("Anna", "Barb", "Charlie", "Alex", "Peter", "Zoe", "Jim");
77-
assertThat(school.roster(), is(expected));
63+
assertEquals(expected, school.roster());
7864
}
7965

8066
@Ignore("Remove to run test")
8167
@Test
8268
public void gradeReturnsTheStudentsInThatGradeInAlphabeticalOrder() {
83-
school = new School();
8469
school.add("Franklin", 5);
8570
school.add("Bradley", 5);
8671
school.add("Jeff", 1);
8772
List<String> expected = Arrays.asList("Bradley", "Franklin");
88-
assertThat(school.grade(5), is(expected));
73+
assertEquals(expected, school.grade(5));
8974
}
9075

9176
@Ignore("Remove to run test")
9277
@Test
9378
public void gradeReturnsAnEmptyListIfThereAreNoStudentsInThatGrade() {
94-
school = new School();
9579
List<String> expected = Arrays.asList();
96-
assertThat(school.grade(1), is(expected));
80+
assertEquals(expected, school.grade(1));
9781
}
9882
}

0 commit comments

Comments
 (0)